OrgUsers: Refactor change LastSeenAtAge from '10 years' to 'Never'
#84247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eleijonmarck
added
type/bug
no-changelog
eleijonmarck
changed the title
LastSeenAtAge to NeverLastSeenAtAge from '10 years' to 'Never'
|
This PR must be merged before a backport PR will be created. |
mgyongyosi
reviewed
Mar 12, 2024
| @@ -107,7 +108,9 @@ export const OrgUsersTable = ({ | |||
| { | |||
| id: 'lastSeenAtAge', | |||
| header: 'Last active', | |||
| cell: ({ cell: { value } }: Cell<'lastSeenAtAge'>) => value, | |||
| cell: ({ cell: { value } }: Cell<'lastSeenAtAge'>) => { | |||
| return <>{value && <>{value === '10 years' ? <Text color={'disabled'}>Never</Text> : value}</>}</>; | |||
There was a problem hiding this comment.
Suggested change
| return <>{value && <>{value === '10 years' ? <Text color={'disabled'}>Never</Text> : value}</>}</>; | |
| return <>{value && value === '10 years' ? <Text color={'disabled'}>Never</Text> : value}</>; |
There was a problem hiding this comment.
changed in the OrgUsersTable.tsx and the UsersTable.tsx
There was a problem hiding this comment.
@eleijonmarck Let me correct myself, the change that I recommended changes the result if value === undefined (however I don't think the value could be undefined), so your first solution was right, could you please revert this change and the other one? Sorry 😇
There was a problem hiding this comment.
@mgyongyosi i tested out the changes locally 🤔 i think. let me first try locally again
Jguer
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
All users table shows
Neverwhen a user has never logged in. In the user organization tab we show10 yearsfrom previous implementation. This changes toNeverin the org tab.Why do we need this feature?
Aligning the all users table to the org users table.