Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Users: Add back check for undefined / null for value for lastSeenAtAge in table view #84265

Merged
merged 1 commit into from Mar 12, 2024
Merged

Users: Add back check for undefined / null for value for lastSeenAtAge in table view #84265

merged 1 commit into from Mar 12, 2024

Conversation

eleijonmarck
Copy link
Contributor

@eleijonmarck eleijonmarck commented Mar 12, 2024 •
edited

What is this feature?
With #84247, we removed a defensive check for undefined for the LastSeenAtAge field being populated from the backend.

This PR adds the check back.

@eleijonmarck eleijonmarck added no-changelog Skip including change in changelog/release notes backport v10.4.x labels Mar 12, 2024
@eleijonmarck eleijonmarck added this to the 11.0.x milestone Mar 12, 2024
@eleijonmarck eleijonmarck self-assigned this Mar 12, 2024
@eleijonmarck eleijonmarck requested a review from a team as a code owner March 12, 2024 11:36
@grafana grafana deleted a comment from grafana-delivery-bot bot Mar 12, 2024
@grafana grafana deleted a comment from grafana-delivery-bot bot Mar 12, 2024
@eleijonmarck eleijonmarck merged commit 0cb9f2b into main Mar 12, 2024
31 checks passed
@eleijonmarck eleijonmarck deleted the eleijonmarck/usertables/defensivecheckforlastseen branch March 12, 2024 13:22
grafana-delivery-bot bot pushed a commit that referenced this pull request Mar 12, 2024
@eleijonmarck @grafana-delivery-bot
Users: Add back check for undefined / null for value for `lastSeenAtA…
2552e1d 
…ge` in table view (#84265)

bug: add check for undefined / null for value
(cherry picked from commit 0cb9f2b)
@grafana-delivery-bot grafana-delivery-bot bot mentioned this pull request Mar 12, 2024
Merged
eleijonmarck added a commit that referenced this pull request Mar 12, 2024
@grafana-delivery-bot @eleijonmarck
[v10.4.x] Users: Add back check for undefined / null for value for `l…
1d58241 
…astSeenAtAge` in table view (#84285)

Users: Add back check for undefined / null for value for `lastSeenAtAge` in table view (#84265)

bug: add check for undefined / null for value
(cherry picked from commit 0cb9f2b)

Co-authored-by: Eric Leijonmarck <eric.leijonmarck@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgyongyosi mgyongyosi mgyongyosi approved these changes

Assignees

@eleijonmarck eleijonmarck

Labels
area/frontend backport v10.4.x no-changelog Skip including change in changelog/release notes type/bug
Projects
None yet
Milestone
11.0.0-preview
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eleijonmarck @mgyongyosi @fabrizio-grafana