New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auth: add the missing fields for all SSO providers #83813
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
c4e09b9
add the missing fields for sso providers
dmihai 5d68d0b
Merge branch 'main' into dmihai/sso-config-pages
dmihai 7c91a3e
remove fields array
dmihai c643ee5
add the validate_hd field for google
dmihai a7fa069
submit only fields defined on the provider
dmihai eb0e280
fix unit tests
dmihai cdcf35d
add unit tests for the new fields/sections from the form
dmihai 063772f
Merge branch 'main' into dmihai/sso-config-pages
dmihai 51fa914
add hosted_domain field for the google provider
dmihai 60f2e5d
Merge remote-tracking branch 'origin/main' into dmihai/sso-config-pages
mgyongyosi 9196315
reorder fields in user mapping
dmihai dfb97cb
Merge remote-tracking branch 'origin/dmihai/sso-config-pages' into dm…
dmihai 4a90197
remove authStyle field from gitlab and okta
dmihai 7f7c11c
Merge branch 'main' into dmihai/sso-config-pages
dmihai File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add the
validate_hd
setting? #83229There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the new field
validate_hd
. Can you please check the description I added to it? https://github.com/grafana/grafana/blob/dmihai/sso-config-pages/public/app/features/auth-config/fields.tsx#L595-L600