Auth: add the missing fields for all SSO providers #83813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgyongyosi
reviewed
Mar 4, 2024
| fields: ['allowAssignGrafanaAdmin', 'roleAttributePath', 'roleAttributeStrict', 'skipOrgRoleSync'], | ||
| }, | ||
| { | ||
| name: 'Extra security measures', |
There was a problem hiding this comment.
Could you please add the validate_hd setting? #83229
There was a problem hiding this comment.
I added the new field validate_hd. Can you please check the description I added to it? https://github.com/grafana/grafana/blob/dmihai/sso-config-pages/public/app/features/auth-config/fields.tsx#L595-L600
# Conflicts: # public/app/features/auth-config/fields.tsx
mgyongyosi
reviewed
Mar 18, 2024
| { | ||
| name: 'User mapping', | ||
| id: 'user', | ||
| fields: ['allowAssignGrafanaAdmin', 'roleAttributePath', 'roleAttributeStrict', 'skipOrgRoleSync'], |
There was a problem hiding this comment.
Please fix the order of these in each of the new configurations. The order should be (based on generic_oauth): 'roleAttributePath', 'roleAttributeStrict','allowAssignGrafanaAdmin','skipOrgRoleSync'.
Thanks!
There was a problem hiding this comment.
Fixed this for all providers.
mgyongyosi
reviewed
Mar 18, 2024
| 'clientId', | ||
| 'clientSecret', | ||
| 'scopes', | ||
| 'authStyle', |
mgyongyosi
reviewed
Mar 18, 2024
| 'clientId', | ||
| 'clientSecret', | ||
| 'scopes', | ||
| 'authStyle', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Add all config fields for the SSO providers in the UI.
Why do we need this feature?
For SSO Settings API.
Who is this feature for?
everybody
Which issue(s) does this PR fix?:
Fixes #
Special notes for your reviewer:
Please check that: