Support venv and use of github actions for contributors #1122
+18
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 19, 2024
lurch
reviewed
Feb 23, 2024
| @@ -62,7 +62,9 @@ gpiozero_mock_pin_classes = | |||
| mocktriggerpin = gpiozero.pins.mock:MockTriggerPin | |||
|
|
|||
| [tool:pytest] | |||
| addopts = -rsx --cov --tb=short | |||
| # addopts = -rsx --cov --tb=short | |||
| # Uncomment the above line to provide basic coverage information in local runs | |||
There was a problem hiding this comment.
I assume that this was enabled for a reason, so perhaps it should be left enabled by default? 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1109
The current .gitignore, setup.py and test.yml are focussed on a specific development set up.
These changes support a few additional development setup preferences without breaking anything. (Do no harm):
Each of these adjustments do no harm, and are individually committed to allow for cherry-picking if there is something you do not like.
If these changes are not integrated into the main codebase then any PRs raised by someone who has made a similar adjustment to support their environment will either silently include them or need rebasing before raising and then be prone to error due to a large number of changes suddenly being present in working tree, regression testing not executing etc. on the final code included in the PR.
A note on codecov.io - the action will do nothing if the repo is not previously linked, so there is no data uploaded etc. unless the repo owner has specifically set this up in advance. I.e. no harm in the action being present at the end of the pipeline.