Fix class graph generation #1124
Open
+885
−793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regenerating the class diagrams for the docs leads to blank diagrams (dot, png & svg files are affected). This occurs via both
make docandmake previewThe issue appears to have been that the search path
gpiozero/**/*.pywas split intogpiozero/**, as the base search path and*.pyas the glob pattern.I have simply adjusted the approach to take
PROJECT_ROOTas the base path and the entiresearch_pathas the glob.Additionally I have committed the regenerated images which appear, to my eye, to contain all the correct elements but have a new layout, probably due to improvements in the generation algorithm.
Feel free to cherry pick the last 2 commits from this set, if you don't want the extra changes as described in #1122
This closes #1123