Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bazel: build_gen does not include Go & Java deps for google/api proto deps #62

Closed
noahdietz opened this issue Aug 17, 2021 · 0 comments · Fixed by #63
Closed

bazel: build_gen does not include Go & Java deps for google/api proto deps #62

noahdietz opened this issue Aug 17, 2021 · 0 comments · Fixed by #63
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@noahdietz
Copy link
Contributor

Recently, the google/monitoring/v3 API attempted to update their BUILD.bazel file with build_gen. The result of that was the removal of the google/api Java & Go proto_library dependencies from the {lang}_gapic_library targets. This broke their build. build_gen should not do this.
@noahdietz noahdietz added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Aug 17, 2021
@noahdietz noahdietz mentioned this issue Aug 17, 2021
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Aug 17, 2021
@noahdietz
fix(bazel): retain certain google/api deps (#63)
455392f 
Fixes #62
gcf-merge-on-green bot pushed a commit that referenced this issue Aug 19, 2021
@release-please
chore: release 0.6.0 (#51)
bd44234 
🤖 I have created a release \*beep\* \*boop\*
---
## [0.6.0](https://www.github.com/googleapis/rules_gapic/compare/v0.5.5...v0.6.0) (2021-08-19)


### Features

* **build_gen:** add service_yaml to java_gapic_library ([#45](https://www.github.com/googleapis/rules_gapic/issues/45)) ([7db0098](https://www.github.com/googleapis/rules_gapic/commit/7db0098351882d1e06b8a4842f361b5be15a59bb))
* **build_gen:** inject Locations mixin proto deps ([#52](https://www.github.com/googleapis/rules_gapic/issues/52)) ([15c1f88](https://www.github.com/googleapis/rules_gapic/commit/15c1f88c64901bfa67a908efeaa4de850a8e8c7a))


### Bug Fixes

* **bazel:** include gapic_yaml in java if present ([#65](https://www.github.com/googleapis/rules_gapic/issues/65)) ([2b6fc8e](https://www.github.com/googleapis/rules_gapic/commit/2b6fc8e06faf86070683bcce4db241060dba8f73))
* **bazel:** retain certain google/api deps ([#63](https://www.github.com/googleapis/rules_gapic/issues/63)) ([455392f](https://www.github.com/googleapis/rules_gapic/commit/455392f678df6097b7a7089b0932475eba3a5a70)), closes [#62](https://www.github.com/googleapis/rules_gapic/issues/62)
* **bazel:** use None when no service_yaml ([#54](https://www.github.com/googleapis/rules_gapic/issues/54)) ([7bdaf87](https://www.github.com/googleapis/rules_gapic/commit/7bdaf871ef364818fa02247e1a001891d3f43091))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(bazel): retain certain google/api deps noahdietz/rules_gapic
1 participant
@noahdietz