Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build_gen): add service_yaml to java_gapic_library #45

Merged
merged 3 commits into from
Jun 22, 2021

Conversation

noahdietz
Copy link
Contributor

@noahdietz noahdietz commented Jun 7, 2021

Generate java_gapic_library with service_yaml attribute populated with the Service config YAML file label.

This is necessary for upcoming mixins support.

Also adds --test_output=errors to the bazel test invocation so that we can see in the Action logs what actually failed.

@noahdietz noahdietz requested a review from a team as a code owner June 7, 2021 18:24
@noahdietz noahdietz requested a review from miraleung June 7, 2021 18:24
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 7, 2021
@noahdietz noahdietz added the automerge Merge the pull request once unit tests and other checks pass. label Jun 7, 2021
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

1 similar comment
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed automerge Merge the pull request once unit tests and other checks pass. labels Jun 8, 2021
@noahdietz
Copy link
Contributor Author

Bump @miraleung

@miraleung
Copy link
Contributor

Will revisit this after removing the allowlist from the Java microgenerator.

@miraleung
Copy link
Contributor

Will ack this when we have a new release of the Java microgenerator (ETA EOW).

Copy link
Contributor

@miraleung miraleung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the 1.0.15 release of the Java microgenerator.

@noahdietz noahdietz added the automerge Merge the pull request once unit tests and other checks pass. label Jun 22, 2021
@noahdietz noahdietz merged commit 7db0098 into googleapis:main Jun 22, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 22, 2021
@noahdietz noahdietz deleted the java-service-yaml branch June 22, 2021 21:17
gcf-merge-on-green bot pushed a commit that referenced this pull request Aug 19, 2021
🤖 I have created a release \*beep\* \*boop\*
---
## [0.6.0](https://www.github.com/googleapis/rules_gapic/compare/v0.5.5...v0.6.0) (2021-08-19)


### Features

* **build_gen:** add service_yaml to java_gapic_library ([#45](https://www.github.com/googleapis/rules_gapic/issues/45)) ([7db0098](https://www.github.com/googleapis/rules_gapic/commit/7db0098351882d1e06b8a4842f361b5be15a59bb))
* **build_gen:** inject Locations mixin proto deps ([#52](https://www.github.com/googleapis/rules_gapic/issues/52)) ([15c1f88](https://www.github.com/googleapis/rules_gapic/commit/15c1f88c64901bfa67a908efeaa4de850a8e8c7a))


### Bug Fixes

* **bazel:** include gapic_yaml in java if present ([#65](https://www.github.com/googleapis/rules_gapic/issues/65)) ([2b6fc8e](https://www.github.com/googleapis/rules_gapic/commit/2b6fc8e06faf86070683bcce4db241060dba8f73))
* **bazel:** retain certain google/api deps ([#63](https://www.github.com/googleapis/rules_gapic/issues/63)) ([455392f](https://www.github.com/googleapis/rules_gapic/commit/455392f678df6097b7a7089b0932475eba3a5a70)), closes [#62](https://www.github.com/googleapis/rules_gapic/issues/62)
* **bazel:** use None when no service_yaml ([#54](https://www.github.com/googleapis/rules_gapic/issues/54)) ([7bdaf87](https://www.github.com/googleapis/rules_gapic/commit/7bdaf871ef364818fa02247e1a001891d3f43091))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants