fix(blob): extract padding chars from hashes #240
Closed
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I didn't previously understand that the "==" at the end of the hash isn't merely a delimiter, but a padding character for base64 encoding. It's not strictly necessary to have it, but you have to add it back in to perform a base64 decode. Base64 encoded strings are padded out to a multiple of four characters.
google-cla
bot
added
the
cla: yes
|
Thanks for the fix! Closing because #238 is already reviewed, and adds a system test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't previously understand that the "==" at the end of the hash
isn't merely a delimiter, but a padding character for base64 encoding.
It's not strictly necessary to have it, but you have to add it back in
to perform a base64 decode. Base64 encoded strings are padded out to
a multiple of four characters.
https://en.wikipedia.org/wiki/Base64#Output_padding