feat: Add dead lettering max delivery attempts argument #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add functionality so users could set max_delivery_attempts while creating or updating a subscription with dead lettering enabled instead of it's value being set to an arbitrary number.
Make the argument optional and set the value to 5 if the user doesn't set it just like Cloud Pub/Sub does.
… with dead lettering calls Added max delivery attempts parameter to calls to update and create subscriber to match the methods in subscriber.py
product-auto-label
bot
added
the
api: pubsub
google-cla
bot
added
the
cla: yes
danavaziri-ga
changed the title
leahecole
requested changes
Nov 12, 2020
samples/snippets/subscriber_test.py
Outdated
| @@ -208,7 +208,7 @@ def test_create_subscription_with_dead_letter_policy( | |||
| pass | |||
|
|
|||
| subscriber.create_subscription_with_dead_letter_topic( | |||
| PROJECT_ID, TOPIC, SUBSCRIPTION_DLQ, DEAD_LETTER_TOPIC | |||
| PROJECT_ID, TOPIC, SUBSCRIPTION_DLQ, DEAD_LETTER_TOPIC, 10 | |||
There was a problem hiding this comment.
Question for this line and line 222
- What are the values 10 and 20? Why did we choose them to be 10 and 20 and not whatever the default is?
- If we do need to pass them and not use the default, please use a constant (or two if you want to have the separate values 10&20) like the other arguments passed in the tests - it makes for easier maintenance
There was a problem hiding this comment.
I addressed this in a seperate commit 7ad3b6a.
I added two constants one for the default value and one for the updated one. We could call create subscription with the default value, which is what my new commit does. However, the update subscription call should be called with a new value because we are testing to see if max_delivery_attempts changes after the call.
danavaziri-ga
changed the title
leahecole
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
leahecole
reviewed
Nov 13, 2020
samples/snippets/subscriber.py
Outdated
| @@ -108,6 +109,9 @@ def create_subscription_with_dead_letter_topic( | |||
| # TODO(developer): This is an existing dead letter topic that the subscription | |||
| # with dead letter policy will forward dead letter messages to. | |||
| # dead_letter_topic_id = "your-dead-letter-topic-id" | |||
| # TODO(developer): This is an the maximum number of delivery attempts allowed | |||
There was a problem hiding this comment.
"This is the maximum number of delivery attempts allowed for a message before it gets delivered to a dead letter topic."
There was a problem hiding this comment.
nit: I think you still forgot the cross out "an" in "This is an the"
There was a problem hiding this comment.
Thank you for pointing that out!
samples/snippets/subscriber.py
Outdated
Comment on lines
285
to
287
| # TODO(developer): This is an the maximum number of delivery attempts allowed | ||
| # before a message gets dead lettered. | ||
| # max_delivery_attempts = "your-max-delivery-attempts" |
anguillanneuf
approved these changes
Nov 13, 2020
danavaziri-ga
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
leahecole
approved these changes
Nov 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add optional max_delivery_attempts argument to sample code to more closely resemble Cloud Pub/Sub behavior.
Fixes #235 🦕