Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
feat: Add dead lettering max delivery attempts argument (#236)
* Add max_delivery_attempts input to subsciber.py Add functionality so users could set max_delivery_attempts while creating or updating a subscription with dead lettering enabled instead of it's value being set to an arbitrary number. * Make max_delivery_attempts argument optional Make the argument optional and set the value to 5 if the user doesn't set it just like Cloud Pub/Sub does. * Add max_delivery_attempts parameter to create and update subscription with dead lettering calls Added max delivery attempts parameter to calls to update and create subscriber to match the methods in subscriber.py * Add constants and defaults for max_delivery_attempts argument * Fix comments related to added max_delivery_attempts parameter * Fix typo in max_delivery_attempts comments
- Loading branch information
1 parent
94d738c
commit 7687ae5
Showing
2 changed files
with
36 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters