Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add dead lettering max delivery attempts argument #236

Merged
merged 7 commits into from Nov 16, 2020
Merged

feat: Add dead lettering max delivery attempts argument #236

merged 7 commits into from Nov 16, 2020

Commits on Nov 10, 2020

  1. Add max_delivery_attempts input to subsciber.py 

    Add functionality so users could set max_delivery_attempts while creating or updating a subscription with dead lettering enabled instead of it's value being set to an arbitrary number.
    @danavaziri-ga
    danavaziri-ga committed Nov 10, 2020
    Copy the full SHA
    d8e9047 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2020

  1. Make max_delivery_attempts argument optional 

    Make the argument optional and set the value to 5 if the user doesn't set it just like Cloud Pub/Sub does.
    @danavaziri-ga
    danavaziri-ga committed Nov 11, 2020
    Copy the full SHA
    911300e View commit details
    Browse the repository at this point in the history

  2. Add max_delivery_attempts parameter to create and update subscription… 

    … with dead lettering calls

Added max delivery attempts parameter to calls to update and create subscriber to match the methods in subscriber.py
    @danavaziri-ga
    danavaziri-ga committed Nov 11, 2020
    Copy the full SHA
    28569e5 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2020

  1. Merge branch 'master' into patch-1

    @danavaziri-ga
    danavaziri-ga committed Nov 13, 2020
    Copy the full SHA
    5fb0431 View commit details
    Browse the repository at this point in the history

  2. Add constants and defaults for max_delivery_attempts argument

    @danavaziri-ga
    danavaziri-ga committed Nov 13, 2020
    Copy the full SHA
    7ad3b6a View commit details
    Browse the repository at this point in the history

  3. Fix comments related to added max_delivery_attempts parameter

    @danavaziri-ga
    danavaziri-ga committed Nov 13, 2020
    Copy the full SHA
    332bcce View commit details
    Browse the repository at this point in the history

  4. Fix typo in max_delivery_attempts comments

    @danavaziri-ga
    danavaziri-ga committed Nov 13, 2020
    Copy the full SHA
    52db582 View commit details
    Browse the repository at this point in the history