Skip to content
This repository has been archived by the owner on Oct 16, 2023. It is now read-only.

chore: prepare for monorepo migration #296

Merged
merged 1 commit into from Aug 14, 2023
Merged

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Aug 14, 2023

This PR migrates to a standard owlbot.py file, instead of a customized one.

Here are the commands that I used to validate the change

  • In a clone of googleapis/googleapis, run
    bazel build //google/iam/credentials/v1:iam-credentials-v1-py
    bazel build //google/iam/v2:iam-v2-py
    bazel build //google/iam/v2beta:iam-v2beta-py

  • In this branch, run owlbot copy code and the owlbot post processor

docker run --rm --user $(id -u):$(id -g)   -v $(pwd):/repo   -v $HOME/git/googleapis/bazel-bin:/bazel-bin   gcr.io/cloud-devrel-public-resources/owlbot-cli:latest copy-bazel-bin   --source-dir /bazel-bin --dest /repo
docker run --user $(id -u):$(id -g) --rm -v $(pwd):/repo -w /repo gcr.io/cloud-devrel-public-resources/owlbot-python:latest

Background

The repository googleapis/python-iam contains code for 2 APIs google/iam/credentials and google/iam

The PR is removing custom logic in owlbot.py, and making the necessary changes in .Owlbot.yaml instead.

@parthea parthea requested a review from a team as a code owner August 14, 2023 20:31
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: iam Issues related to the googleapis/python-iam API. labels Aug 14, 2023
@@ -4,8 +4,8 @@ branch = True
[report]
show_missing = True
omit =
google/cloud/iam_credentials/__init__.py
google/cloud/iam_credentials/gapic_version.py
google/cloud/iam/__init__.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im Java iam and iamcredentials are different library. If this change is intentional, that's fine.

Copy link
Contributor Author

@parthea parthea Aug 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acknowledged. iamcredentials was shipped first as google-cloud-iam instead of google-cloud-iamcredentials. I think this is what caused us to merge the 2 APIs. When google/iam v2/v2beta came along we decided to add them to the existing google-cloud-iam package. We don't have plans to split up iam and iamcredentials. Let's continue the discussion in googleapis/google-cloud-python#11572 which mentions consolidating iam APIs.

@parthea parthea merged commit 600e045 into main Aug 14, 2023
17 checks passed
@parthea parthea deleted the migrate-to-standard-owlbot-py branch August 14, 2023 20:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: iam Issues related to the googleapis/python-iam API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants