Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt split repo: _python-iam_ #11044

Closed
vchudnov-g opened this issue Apr 5, 2023 · 2 comments
Closed

Adopt split repo: _python-iam_ #11044

vchudnov-g opened this issue Apr 5, 2023 · 2 comments
Labels
migration:issues:none Split repo to be migrated here had no open issues when last checked migration:library:gapic_auto Library type of the split repo to be migrated here migration:pr:none Split repo to be migrated has no pending PRs migration:ready migration:samples:generated Split repo to be migrated here has generated samples migration:stage:common-files-updated Migration stage finished: central monorepo files changed ("post-process" PR submitted) migration:stage:git-history-merged Migration stage finished: finished merging githistory (PR submitted) migration:stage:split-repo-archived Migration stage finished: the split repo has been archived. migration:stage:split-repo-trimmed Migration stage finished: the split repo has been pared down (PR submitted) migration:testing:unit Split repo to be migrated here has unit tests migration:workaround:none Split repo to be migrated here has no manual workarounds

Comments

@vchudnov-g
Copy link
Contributor

vchudnov-g commented Apr 5, 2023 •
edited

Migrate the split-repo https://github.com/googleapis/python-iam to https://github.com/googleapis/google-cloud-python.

The migration readiness criteria are the following, which we track via GitHub labels on this issue. These criteria apply to the split repo we are migrating from:

  • No open issues
  • No open PRs
  • No handwritten samples
  • No system tests
  • No client-specific customizations
@vchudnov-g vchudnov-g added migration:samples:generated Split repo to be migrated here has generated samples migration:workaround:owlbot Split repo to be migrated here has owlbot workarounds migration:library:gapic_auto Library type of the split repo to be migrated here migration:testing:unit Split repo to be migrated here has unit tests migration:issues:open Split repo to be migrated here has open issues when last checked labels Apr 5, 2023
@parthea
Copy link
Contributor

parthea commented Apr 5, 2023

The repository includes clients from 2 different APIs : iamcredentials and iam. This is not supported in the mono repository yet. I'm going to add the blocked tag while I investigate how we can support it.

FYI @vchudnov-g

@parthea parthea added the status: blocked Resolving the issue is dependent on other work. label Apr 5, 2023
@parthea parthea self-assigned this Apr 5, 2023
@vchudnov-g vchudnov-g changed the title Adopt split repo: python-iam Adopt split repo: _python-iam_ Apr 6, 2023
@vchudnov-g vchudnov-g added the migration:pr:none Split repo to be migrated has no pending PRs label Apr 6, 2023
@parthea parthea removed their assignment Apr 6, 2023
@parthea parthea added migration:pr:pending Split repo to be migrated has pending PRs migration:pr:none Split repo to be migrated has no pending PRs and removed migration:pr:none Split repo to be migrated has no pending PRs migration:pr:pending Split repo to be migrated has pending PRs labels May 31, 2023
@parthea parthea removed the status: blocked Resolving the issue is dependent on other work. label Aug 14, 2023
@parthea
Copy link
Contributor

parthea commented Aug 14, 2023

The issue mentioned in #11044 (comment) was fixed in googleapis/python-iam#296

@parthea parthea added migration:ready migration:issues:none Split repo to be migrated here had no open issues when last checked migration:workaround:none Split repo to be migrated here has no manual workarounds and removed migration:workaround:owlbot Split repo to be migrated here has owlbot workarounds migration:issues:open Split repo to be migrated here has open issues when last checked labels Aug 15, 2023
This was referenced Aug 15, 2023
Merged
Merged
parthea added a commit that referenced this issue Aug 16, 2023
@parthea
chore(migration): Migrate code from googleapis/python-iam into packag…
2386577 
…es/google-cloud-iam (#11578)

See #11044. 

This PR should be merged with a merge-commit, not a squash-commit, in
order to preserve the git history.
@parthea parthea added migration:stage:git-history-merged Migration stage finished: finished merging githistory (PR submitted) migration:stage:common-files-updated Migration stage finished: central monorepo files changed ("post-process" PR submitted) migration:stage:split-repo-trimmed Migration stage finished: the split repo has been pared down (PR submitted) migration:stage:split-repo-archived Migration stage finished: the split repo has been archived. labels Aug 16, 2023
@parthea parthea closed this as completed Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
migration:issues:none Split repo to be migrated here had no open issues when last checked migration:library:gapic_auto Library type of the split repo to be migrated here migration:pr:none Split repo to be migrated has no pending PRs migration:ready migration:samples:generated Split repo to be migrated here has generated samples migration:stage:common-files-updated Migration stage finished: central monorepo files changed ("post-process" PR submitted) migration:stage:git-history-merged Migration stage finished: finished merging githistory (PR submitted) migration:stage:split-repo-archived Migration stage finished: the split repo has been archived. migration:stage:split-repo-trimmed Migration stage finished: the split repo has been pared down (PR submitted) migration:testing:unit Split repo to be migrated here has unit tests migration:workaround:none Split repo to be migrated here has no manual workarounds
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@parthea @vchudnov-g