#12: fix incorrectly checked value of request parameters

google/cloud/compute_v1/services/accelerator_types/transports/rest.py

@@ -137,7 +137,7 @@ def aggregated_list(
         #               discards default values
         # TODO(yon-mg): add test for proper url encoded strings
         query_params = [
-            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
+            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
         ]
         url += "?{}".format("&".join(query_params)).replace(" ", "+")
 
@@ -197,7 +197,7 @@ def get(
         #               discards default values
         # TODO(yon-mg): add test for proper url encoded strings
         query_params = [
-            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
+            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
         ]
         url += "?{}".format("&".join(query_params)).replace(" ", "+")
 
@@ -252,7 +252,7 @@ def list(
         #               discards default values
         # TODO(yon-mg): add test for proper url encoded strings
         query_params = [
-            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
+            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
         ]
         url += "?{}".format("&".join(query_params)).replace(" ", "+")
 

google/cloud/compute_v1/services/addresses/transports/rest.py

@@ -136,7 +136,7 @@ def aggregated_list(
         #               discards default values
         # TODO(yon-mg): add test for proper url encoded strings
         query_params = [
-            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
+            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
         ]
         url += "?{}".format("&".join(query_params)).replace(" ", "+")
 
@@ -218,7 +218,7 @@ def delete(
         #               discards default values
         # TODO(yon-mg): add test for proper url encoded strings
         query_params = [
-            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
+            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
         ]
         url += "?{}".format("&".join(query_params)).replace(" ", "+")
 
@@ -297,7 +297,7 @@ def get(
         #               discards default values
         # TODO(yon-mg): add test for proper url encoded strings
         query_params = [
-            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
+            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
         ]
         url += "?{}".format("&".join(query_params)).replace(" ", "+")
 
@@ -381,7 +381,7 @@ def insert(
         #               discards default values
         # TODO(yon-mg): add test for proper url encoded strings
         query_params = [
-            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
+            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
         ]
         url += "?{}".format("&".join(query_params)).replace(" ", "+")
 
@@ -435,7 +435,7 @@ def list(
         #               discards default values
         # TODO(yon-mg): add test for proper url encoded strings
         query_params = [
-            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
+            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
         ]
         url += "?{}".format("&".join(query_params)).replace(" ", "+")
 

google/cloud/compute_v1/services/autoscalers/transports/rest.py

@@ -136,7 +136,7 @@ def aggregated_list(
         #               discards default values
         # TODO(yon-mg): add test for proper url encoded strings
         query_params = [
-            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
+            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
         ]
         url += "?{}".format("&".join(query_params)).replace(" ", "+")
 
@@ -218,7 +218,7 @@ def delete(
         #               discards default values
         # TODO(yon-mg): add test for proper url encoded strings
         query_params = [
-            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
+            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
         ]
         url += "?{}".format("&".join(query_params)).replace(" ", "+")
 
@@ -290,7 +290,7 @@ def get(
         #               discards default values
         # TODO(yon-mg): add test for proper url encoded strings
         query_params = [
-            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
+            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
         ]
         url += "?{}".format("&".join(query_params)).replace(" ", "+")
 
@@ -374,7 +374,7 @@ def insert(
         #               discards default values
         # TODO(yon-mg): add test for proper url encoded strings
         query_params = [
-            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
+            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
         ]
         url += "?{}".format("&".join(query_params)).replace(" ", "+")
 
@@ -431,7 +431,7 @@ def list(
         #               discards default values
         # TODO(yon-mg): add test for proper url encoded strings
         query_params = [
-            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
+            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
         ]
         url += "?{}".format("&".join(query_params)).replace(" ", "+")
 
@@ -516,7 +516,7 @@ def patch(
         #               discards default values
         # TODO(yon-mg): add test for proper url encoded strings
         query_params = [
-            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
+            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
         ]
         url += "?{}".format("&".join(query_params)).replace(" ", "+")
 
@@ -601,7 +601,7 @@ def update(
         #               discards default values
         # TODO(yon-mg): add test for proper url encoded strings
         query_params = [
-            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
+            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
         ]
         url += "?{}".format("&".join(query_params)).replace(" ", "+")
 

google/cloud/compute_v1/services/backend_buckets/transports/rest.py

@@ -166,7 +166,7 @@ def add_signed_url_key(
         #               discards default values
         # TODO(yon-mg): add test for proper url encoded strings
         query_params = [
-            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
+            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
         ]
         url += "?{}".format("&".join(query_params)).replace(" ", "+")
 
@@ -247,7 +247,7 @@ def delete(
         #               discards default values
         # TODO(yon-mg): add test for proper url encoded strings
         query_params = [
-            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
+            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
         ]
         url += "?{}".format("&".join(query_params)).replace(" ", "+")
 
@@ -329,7 +329,7 @@ def delete_signed_url_key(
         #               discards default values
         # TODO(yon-mg): add test for proper url encoded strings
         query_params = [
-            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
+            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
         ]
         url += "?{}".format("&".join(query_params)).replace(" ", "+")
 
@@ -386,7 +386,7 @@ def get(
         #               discards default values
         # TODO(yon-mg): add test for proper url encoded strings
         query_params = [
-            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
+            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
         ]
         url += "?{}".format("&".join(query_params)).replace(" ", "+")
 
@@ -470,7 +470,7 @@ def insert(
         #               discards default values
         # TODO(yon-mg): add test for proper url encoded strings
         query_params = [
-            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
+            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
         ]
         url += "?{}".format("&".join(query_params)).replace(" ", "+")
 
@@ -527,7 +527,7 @@ def list(
         #               discards default values
         # TODO(yon-mg): add test for proper url encoded strings
         query_params = [
-            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
+            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
         ]
         url += "?{}".format("&".join(query_params)).replace(" ", "+")
 
@@ -613,7 +613,7 @@ def patch(
         #               discards default values
         # TODO(yon-mg): add test for proper url encoded strings
         query_params = [
-            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
+            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
         ]
         url += "?{}".format("&".join(query_params)).replace(" ", "+")
 
@@ -699,7 +699,7 @@ def update(
         #               discards default values
         # TODO(yon-mg): add test for proper url encoded strings
         query_params = [
-            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
+            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
         ]
         url += "?{}".format("&".join(query_params)).replace(" ", "+")
 

google/cloud/compute_v1/services/backend_services/transports/rest.py

@@ -166,7 +166,7 @@ def add_signed_url_key(
         #               discards default values
         # TODO(yon-mg): add test for proper url encoded strings
         query_params = [
-            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
+            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
         ]
         url += "?{}".format("&".join(query_params)).replace(" ", "+")
 
@@ -224,7 +224,7 @@ def aggregated_list(
         #               discards default values
         # TODO(yon-mg): add test for proper url encoded strings
         query_params = [
-            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
+            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
         ]
         url += "?{}".format("&".join(query_params)).replace(" ", "+")
 
@@ -305,7 +305,7 @@ def delete(
         #               discards default values
         # TODO(yon-mg): add test for proper url encoded strings
         query_params = [
-            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
+            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
         ]
         url += "?{}".format("&".join(query_params)).replace(" ", "+")
 
@@ -387,7 +387,7 @@ def delete_signed_url_key(
         #               discards default values
         # TODO(yon-mg): add test for proper url encoded strings
         query_params = [
-            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
+            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
         ]
         url += "?{}".format("&".join(query_params)).replace(" ", "+")
 
@@ -460,7 +460,7 @@ def get(
         #               discards default values
         # TODO(yon-mg): add test for proper url encoded strings
         query_params = [
-            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
+            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
         ]
         url += "?{}".format("&".join(query_params)).replace(" ", "+")
 
@@ -517,7 +517,7 @@ def get_health(
         #               discards default values
         # TODO(yon-mg): add test for proper url encoded strings
         query_params = [
-            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
+            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
         ]
         url += "?{}".format("&".join(query_params)).replace(" ", "+")
 
@@ -601,7 +601,7 @@ def insert(
         #               discards default values
         # TODO(yon-mg): add test for proper url encoded strings
         query_params = [
-            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
+            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
         ]
         url += "?{}".format("&".join(query_params)).replace(" ", "+")
 
@@ -658,7 +658,7 @@ def list(
         #               discards default values
         # TODO(yon-mg): add test for proper url encoded strings
         query_params = [
-            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
+            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
         ]
         url += "?{}".format("&".join(query_params)).replace(" ", "+")
 
@@ -744,7 +744,7 @@ def patch(
         #               discards default values
         # TODO(yon-mg): add test for proper url encoded strings
         query_params = [
-            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
+            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
         ]
         url += "?{}".format("&".join(query_params)).replace(" ", "+")
 
@@ -831,7 +831,7 @@ def set_security_policy(
         #               discards default values
         # TODO(yon-mg): add test for proper url encoded strings
         query_params = [
-            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
+            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
         ]
         url += "?{}".format("&".join(query_params)).replace(" ", "+")
 
@@ -917,7 +917,7 @@ def update(
         #               discards default values
         # TODO(yon-mg): add test for proper url encoded strings
         query_params = [
-            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
+            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
         ]
         url += "?{}".format("&".join(query_params)).replace(" ", "+")
 

google/cloud/compute_v1/services/disk_types/transports/rest.py

@@ -136,7 +136,7 @@ def aggregated_list(
         #               discards default values
         # TODO(yon-mg): add test for proper url encoded strings
         query_params = [
-            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
+            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
         ]
         url += "?{}".format("&".join(query_params)).replace(" ", "+")
 
@@ -207,7 +207,7 @@ def get(
         #               discards default values
         # TODO(yon-mg): add test for proper url encoded strings
         query_params = [
-            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
+            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
         ]
         url += "?{}".format("&".join(query_params)).replace(" ", "+")
 
@@ -261,7 +261,7 @@ def list(
         #               discards default values
         # TODO(yon-mg): add test for proper url encoded strings
         query_params = [
-            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v
+            "{k}={v}".format(k=k, v=v) for k, v in query_params.items() if v is not None and '' != v
         ]
         url += "?{}".format("&".join(query_params)).replace(" ", "+")