#12: fix incorrectly checked value of request parameters

[igor-solomatov]

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

• Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
• Ensure the tests and linter pass
• Code coverage does not decrease (if any source code was changed)
• Appropriate docs were updated (if necessary)

Fixes #12 🦕

[google-cla]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[igor-solomatov]

@googlebot I signed it!

[busunkim96]

@igor-solomatov Thanks for opening a PR! This library is actually generated from the the discovery representation of the API (see https://github.com/googleapis/googleapis-discovery/tree/master/google/cloud/compute/v1), so we would make any fixes to the source templates: https://github.com/googleapis/gapic-generator-python/tree/master/gapic/templates/%25namespace/%25name_%25version/%25sub/services/%25service/transports

@yon-mg @vam-google Could you take a look at this PR and #12?

[igor-solomatov]

Hi @busunkim96

I saw it is an autogen, but could not find a source of it.

This line is a problem:
https://github.com/googleapis/gapic-generator-python/blob/944136c5ed11af03b1960ac1f0db9f4d0733b381/gapic/templates/%25namespace/%25name_%25version/%25sub/services/%25service/transports/rest.py.j2#L194

[yon-mg]

This is will be addressed in an upcoming pr to the generator that also addresses grpc transcoding in general. I may have misunderstood the issue actually. I'll address this in the original bug.

[parthea]

Hi @yon-mg, please could you add an update to #12 ?

[parthea]

I'm going to close this PR as it is touching auto-generated files. Let's continue the discussion in #12 .