This repository has been archived by the owner on Dec 31, 2023. It is now read-only.
feat: update to the latest version of the code generator #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parthea
added
the
do not merge
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: compute
|
Blocked by googleapis/google-cloud-python#10566 |
parthea
added
the
status: blocked
|
@parthea I chatted about this with @vam-google over chat. This library is relatively new and still in preview, so I think it's reasonable to ask folks to use a newer version of The alternative is back-porting quite a few significant changes to the v1 branch of google-api-core library, which I would prefer not to do at this point. |
parthea
removed
the
status: blocked
….com/googleapis/python-compute into use-the-latest-python-code-generator
….com/googleapis/python-compute into use-the-latest-python-code-generator
parthea
commented
Nov 11, 2021
parthea
removed
the
do not merge
parthea
added
kokoro:force-run
yoshi-kokoro
removed
kokoro:run
|
Those tests that are failing need to be somehow refactored, as they keep failing despite the fact that we use the Do you think turning the two tests that live in test_sample_default_values.py could stop those failures? |
|
Seems like merging the two tests did the trick :) |
parthea
added
automerge
|
@busunkim96 This is ready for review |
busunkim96
reviewed
Nov 12, 2021
|
@busunkim96 Please could you take another look? |
|
This is ready for review |
busunkim96
approved these changes
Nov 16, 2021
parthea
added
the
automerge
gcf-merge-on-green
bot
deleted the
use-the-latest-python-code-generator
branch
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Nov 16, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [0.8.0](https://www.github.com/googleapis/python-compute/compare/v0.7.0...v0.8.0) (2021-11-16) ### Features * support self-signed JWT flow for service accounts ([de739a1](https://www.github.com/googleapis/python-compute/commit/de739a1b2c94648135bf62bc2aff23c2896a9b2d)) * update to the latest version of the code generator ([#147](https://www.github.com/googleapis/python-compute/issues/147)) ([de739a1](https://www.github.com/googleapis/python-compute/commit/de739a1b2c94648135bf62bc2aff23c2896a9b2d)) ### Bug Fixes * add 'dict' annotation type to 'request' ([de739a1](https://www.github.com/googleapis/python-compute/commit/de739a1b2c94648135bf62bc2aff23c2896a9b2d)) * **deps:** require google-api-core >=2.2.0 ([de739a1](https://www.github.com/googleapis/python-compute/commit/de739a1b2c94648135bf62bc2aff23c2896a9b2d)) * **deps:** require proto-plus >=1.19.7 ([de739a1](https://www.github.com/googleapis/python-compute/commit/de739a1b2c94648135bf62bc2aff23c2896a9b2d)) ### Documentation * list oneofs in docstring ([de739a1](https://www.github.com/googleapis/python-compute/commit/de739a1b2c94648135bf62bc2aff23c2896a9b2d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compute protos are now available in googleapis/googleapis, and the generated code is also available in googleapis/googleapis-gen here. This PR pulls in the latest version of the generated client from googleapis-gen, which may have significant differences. I've added the
do not mergelabel while we discuss whether any differences could break user code.This PR also deletes
synth.pyand adds configuration files for owl bot. owl bot will save time for maintainers as it will automatically open PRs when there are updates in googleapis-gen without requiring maintainers to run synthtool to build the client from protos. Additionally, similar to autosynth, PRs will be automatically opened when there are updates to templated files.fix(deps): require google-api-core >=2.2.0
fix(deps): require proto-plus >=1.19.7
docs: list oneofs in docstring
fix: add 'dict' annotation type to 'request'
feat: support self-signed JWT flow for service accounts
chore(samples): Merging usage bucket tests into one, to avoid race conditions