Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google-cloud-compute v0.8.0 #1

Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

@regro-cf-autotick-bot regro-cf-autotick-bot commented Nov 16, 2021

It is very likely that the current package version for this feedstock is out of date.
Notes for merging this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
    Checklist before merging this PR:
  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Note that the bot will stop issuing PRs if more than 3 Version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.

NEW: If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our new bot automerge feature to your feedstock!

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot.
The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable.
Finally, feel free to drop us a line if there are any issues!
This PR was generated by https://github.com/regro/autotick-bot/actions/runs/1468509094, please use this URL for debugging

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis of the source code shows a discrepancy between the library's imports and the package's stated requirements in the meta.yaml.

Packages found by inspection but not in the meta.yaml:

  • google-auth
  • requests
  • grpcio
  • google-api-core

Packages found in the meta.yaml but not found by inspection:

  • google-api-core-grpc
  • packaging

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@tswast
Copy link
Contributor

tswast commented Nov 16, 2021

google-cloud-compute 0.8.0 has requirement proto-plus>=1.19.7, but you have proto-plus 1.19.6.
Tests failed for google-cloud-compute-0.8.0-pyh6c4a22f_0.tar.bz2 - moving package to /home/conda/feedstock_root/build_artifacts/broken
WARNING:conda_build.build:Tests failed for google-cloud-compute-0.8.0-pyh6c4a22f_0.tar.bz2 - moving package to /home/conda/feedstock_root/build_artifacts/broken
WARNING conda_build.build:tests_failed(2970): Tests failed for google-cloud-compute-0.8.0-pyh6c4a22f_0.tar.bz2 - moving package to /home/conda/feedstock_root/build_artifacts/broken
TESTS FAILED: google-cloud-compute-0.8.0-pyh6c4a22f_0.tar.bz2

Looks like we need a https://github.com/conda-forge/proto-plus-feedstock release

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • requirements: run: google-api-core-grpc >= 2.2.0,<3.0.0dev should not contain a space between relational operator and the version, i.e. google-api-core-grpc >=2.2.0,<3.0.0dev

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@tpdownes
Copy link
Member

@tswast This PR also intentionally updates the dependencies above 2.x (a topic we recently discussed)

googleapis/python-compute#147 (comment)

Considered OK because the compute SDK is still 0.x and "forward looking".

@tpdownes
Copy link
Member

google-cloud-compute 0.8.0 has requirement proto-plus>=1.19.7, but you have proto-plus 1.19.6.
Tests failed for google-cloud-compute-0.8.0-pyh6c4a22f_0.tar.bz2 - moving package to /home/conda/feedstock_root/build_artifacts/broken
WARNING:conda_build.build:Tests failed for google-cloud-compute-0.8.0-pyh6c4a22f_0.tar.bz2 - moving package to /home/conda/feedstock_root/build_artifacts/broken
WARNING conda_build.build:tests_failed(2970): Tests failed for google-cloud-compute-0.8.0-pyh6c4a22f_0.tar.bz2 - moving package to /home/conda/feedstock_root/build_artifacts/broken
TESTS FAILED: google-cloud-compute-0.8.0-pyh6c4a22f_0.tar.bz2

Looks like we need a https://github.com/conda-forge/proto-plus-feedstock release

I see you created one that fits the bill. I'll wait for the release. Is there a "right" way to re-trigger the CI?

* update dependencies to match source library
@tswast
Copy link
Contributor

tswast commented Nov 16, 2021

I see you created one that fits the bill. I'll wait for the release. Is there a "right" way to re-trigger the CI?

image

That button should do it. We might have to bump the minimum to 1.19.8 since I skipped the 1.19.7 release since it was broken.

@tpdownes tpdownes added the automerge Merge the PR when CI passes label Nov 16, 2021
@github-actions github-actions bot merged commit 8f211c5 into conda-forge:master Nov 16, 2021
@github-actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 0.8.0_hc3dd54 branch November 16, 2021 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants