Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add quota_project, credentials file, and scopes options #15

Merged
merged 6 commits into from Aug 4, 2020

Conversation

busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Aug 1, 2020

Manual clients need to support the new client_options logic.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 1, 2020
@busunkim96 busunkim96 added this to In progress in Add new client options to Python libraries via automation Aug 3, 2020
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs coverage for the new codepaths in Client.__init__ (options passed as dict, conflict between credentials and client_options.credientials_file, etc.

tests/unit/test_client.py Outdated Show resolved Hide resolved
google/cloud/client.py Outdated Show resolved Hide resolved
@google-cla
Copy link

google-cla bot commented Aug 4, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Aug 4, 2020
@tseaver
Copy link
Contributor

tseaver commented Aug 4, 2020

@googlebot I consent

@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants