Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new client options #210

Closed
busunkim96 opened this issue Jul 22, 2020 · 2 comments · Fixed by #225
Closed

Implement new client options #210

busunkim96 opened this issue Jul 22, 2020 · 2 comments · Fixed by #225
Assignees
@tseaver
Labels
api: storage Issues related to the googleapis/python-storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
Add new client options to Python libr...

Comments

@busunkim96
Copy link
Contributor

Add support for the three new client_options quota_project_id, scopes, and credentials_file.

https://googleapis.dev/python/google-api-core/latest/client_options.html
@busunkim96 busunkim96 added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Jul 22, 2020
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Jul 22, 2020
@tseaver tseaver added the status: blocked Resolving the issue is dependent on other work. label Aug 4, 2020
@tseaver
Copy link
Contributor

tseaver commented Aug 4, 2020

I believe this work is blocked on merge / release of googleapis/python-cloud-core#15

@tseaver tseaver removed the status: blocked Resolving the issue is dependent on other work. label Aug 4, 2020
@tseaver
Copy link
Contributor

tseaver commented Aug 4, 2020

PR needs to pin google-cloud-core >= 1.4.0, < 2.0dev.

@tseaver tseaver self-assigned this Aug 4, 2020
tseaver added a commit that referenced this issue Aug 4, 2020
@tseaver
feat: pass 'client_options' to base class ctor
f2de56f 
packaging: pin 'google-cloud-core >= 1.4.0'

Closes #210
@tseaver tseaver mentioned this issue Aug 4, 2020
Merged
@tseaver tseaver moved this from To do to In progress in Add new client options to Python libraries Aug 4, 2020
Add new client options to Python libraries automation moved this from In progress to Done Aug 5, 2020
gcf-merge-on-green bot pushed a commit that referenced this issue Aug 5, 2020
@tseaver
feat: pass 'client_options' to base class ctor (#225)
e1f91fc 
packaging: pin 'google-cloud-core >= 1.4.0'

Closes #210
cojenco pushed a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
@tseaver @cojenco
feat: pass 'client_options' to base class ctor (googleapis#225)
a5bcadd 
packaging: pin 'google-cloud-core >= 1.4.0'

Closes googleapis#210
cojenco pushed a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
@tseaver @cojenco
feat: pass 'client_options' to base class ctor (googleapis#225)
66505ce 
packaging: pin 'google-cloud-core >= 1.4.0'

Closes googleapis#210
@release-please release-please bot mentioned this issue Jan 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tseaver tseaver

Labels
api: storage Issues related to the googleapis/python-storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
No open projects
Add new client options to Python libr...
  
Done
Milestone
No milestone
2 participants
@tseaver @busunkim96