Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new client options #50

Closed
busunkim96 opened this issue Jul 22, 2020 · 2 comments · Fixed by #60
Closed

Implement new client options #50

busunkim96 opened this issue Jul 22, 2020 · 2 comments · Fixed by #60
Assignees
@tseaver
Labels
api: datastore Issues related to the googleapis/python-datastore API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
Add new client options to Python libr...

Comments

@busunkim96
Copy link
Contributor

Add support for the three new client_options quota_project_id, scopes, and credentials_file. These options are implemented on the mirogenerator, so the completion of the migration may automatically fulfill this.

https://googleapis.dev/python/google-api-core/latest/client_options.html
@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/python-datastore API. label Jul 22, 2020
@busunkim96 busunkim96 added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed api: datastore Issues related to the googleapis/python-datastore API. labels Jul 22, 2020
@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/python-datastore API. label Jul 23, 2020
@tseaver tseaver added the status: blocked Resolving the issue is dependent on other work. label Aug 4, 2020
@tseaver
Copy link
Contributor

tseaver commented Aug 4, 2020

I believe this work is blocked on merge / release of googleapis/python-cloud-core#15

@tseaver tseaver removed the status: blocked Resolving the issue is dependent on other work. label Aug 4, 2020
@tseaver
Copy link
Contributor

tseaver commented Aug 4, 2020

PR needs to pin google-cloud-core >= 1.4.0, < 2.0dev.

@tseaver tseaver self-assigned this Aug 5, 2020
tseaver added a commit that referenced this issue Aug 5, 2020
@tseaver
feat: pass 'client_options' to base class ctor
6efd02a 
packaging: pin 'google-cloud-core >= 1.4.0'

Closes #50.
@tseaver tseaver mentioned this issue Aug 5, 2020
Merged
Add new client options to Python libraries automation moved this from To do to Done Aug 5, 2020
gcf-merge-on-green bot pushed a commit that referenced this issue Aug 5, 2020
@tseaver
feat: pass 'client_options' to base class ctor (#60)
2575697 
packaging: pin 'google-cloud-core >= 1.4.0'

Closes #50.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tseaver tseaver

Labels
api: datastore Issues related to the googleapis/python-datastore API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
No open projects
Add new client options to Python libr...
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: pass 'client_options' to base class ctor googleapis/python-datastore
2 participants
@tseaver @busunkim96