feat: Transfer Manager Metrics #2305
Conversation
product-auto-label
bot
added
size: m
|
First commit is feature-only (no tests) to show it works w/o breaking anything. Working on tests next. |
| @@ -537,7 +539,9 @@ export class Util { | |||
| body: writeStream, | |||
| }, | |||
| ], | |||
| } as {} as r.OptionsWithUri & GCCL_GCS_CMD; | |||
| } as {} as r.OptionsWithUri & { | |||
src/nodejs-common/util.ts
Outdated
| * | ||
| * E.g the `V` in `X-Goog-API-Client: gccl-gcs-cmd/V` | ||
| **/ | ||
| export const GCCL_GCS_CMD_KEY = Symbol('GCCL_GCS_CMD'); |
There was a problem hiding this comment.
Had to go look this up, didn't know Symbol was a thing.
product-auto-label
bot
added
size: l
| transferManager.bucket.storage.authClient = new GoogleAuth({ | ||
| authClient: new TestAuthClient(), | ||
| }); |
There was a problem hiding this comment.
Makes it more of an integration test.
| directory = await fsp.mkdtemp( | ||
| path.join(tmpdir(), 'tm-uploadFileInChunks-') | ||
| ); | ||
|
|
||
| filePath = path.join(directory, 't.txt'); | ||
|
|
||
| await fsp.writeFile(filePath, 'hello'); |
There was a problem hiding this comment.
Sharing a real, temp file to make it more robust. We can refactor the other tests if we want to use the real XML tool w/o exporting it.
There was a problem hiding this comment.
Yea this looks better than the hacky way I had it.
| }, | ||
| idempotencyStrategy: IdempotencyStrategy.RetryConditional, | ||
| }; | ||
| const STORAGE = sinon.stub( |
There was a problem hiding this comment.
Thanks, couldn't figure out the correct way to do this.
| } | ||
|
|
||
| // If the header isn't present, add it | ||
| if (!headerFound) { |
There was a problem hiding this comment.
We'd have to remember to update this line every time we add something new to headers. Is there a better way to do this?
There was a problem hiding this comment.
We can have a centralized place for this, however it would be cleaner to first complete the gaxios migration.
There was a problem hiding this comment.
This is also already matching the pattern in resumable uploads.
There was a problem hiding this comment.
here's an example in #2296.
Yeah, thats fine. Please create a TODO & ticket to follow up
|
PR's ready for review |
🦕