Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Centralize Shared Headers #2314

Open
danielbankhead opened this issue Sep 26, 2023 · 0 comments
Open

feat: Centralize Shared Headers #2314

danielbankhead opened this issue Sep 26, 2023 · 0 comments
Labels
api: storage Issues related to the googleapis/nodejs-storage API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@danielbankhead
Copy link
Member

danielbankhead commented Sep 26, 2023 •
edited

We should centralize shared headers. This can be made cleaner post-gaxios migration.

Discussion: #2305 (comment)

This can also be iterated on in Node 18+ by returning a Headers object (as today headers are case-sensitive while they shouldn't be).
@danielbankhead danielbankhead added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Sep 26, 2023
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/nodejs-storage API. label Sep 26, 2023
@danielbankhead danielbankhead mentioned this issue Sep 26, 2023
Merged
@danielduhh danielduhh added type: cleanup An internal cleanup or hygiene concern. and removed type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/nodejs-storage API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danielduhh @danielbankhead