Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dep)!: upgrade typescript #97

Merged
merged 8 commits into from
Mar 26, 2020
Merged

chore(dep)!: upgrade typescript #97

merged 8 commits into from
Mar 26, 2020

Conversation

summer-ji-eng
Copy link
Contributor

@summer-ji-eng summer-ji-eng commented Mar 24, 2020

upgrade

  • typescript version ^3.8.3

  • gts version 2.0.0

@summer-ji-eng summer-ji-eng requested a review from bcoe March 24, 2020 20:23
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 24, 2020
@codecov
Copy link

codecov bot commented Mar 24, 2020

Codecov Report

Merging #97 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #97   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines         655    656    +1     
  Branches       28     25    -3     
=====================================
+ Hits          655    656    +1
Impacted Files Coverage Δ
src/index.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c4cd2d...a4849a9. Read the comment docs.

package.json Outdated
"codecov": "^3.0.4",
"gts": "^1.0.0",
"gts": "2.0.0-alpha.5",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could just pin this to next for now to always float to the latest

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're getting very close to being able to just cut 2.x.x, I'd rather we're explicit about version, and let renovate do its thing soon.

package.json Show resolved Hide resolved
@bcoe bcoe changed the title chore(dep): upgrade typescript chore(dep)!: upgrade typescript Mar 26, 2020
@bcoe bcoe merged commit 59ca2de into master Mar 26, 2020
@bcoe bcoe deleted the typescript_upgrade branch March 26, 2020 18:32
@release-please release-please bot mentioned this pull request Mar 26, 2020
gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 26, 2020
🤖 I have created a release \*beep\* \*boop\* 
---
## [2.0.0](https://www.github.com/googleapis/nodejs-precise-date/compare/v1.0.3...v2.0.0) (2020-03-26)


### ⚠ BREAKING CHANGES

* **dep:** upgrade typescript/gts (#97)
* **dep:** deprecate Node 8 to 10 (#92)

### Miscellaneous Chores

* **dep:** deprecate Node 8 to 10 ([#92](https://www.github.com/googleapis/nodejs-precise-date/issues/92)) ([75ca209](https://www.github.com/googleapis/nodejs-precise-date/commit/75ca209b49abcba8efcbc401b270ac1346874647))
* **dep:** upgrade typescript/gts ([#97](https://www.github.com/googleapis/nodejs-precise-date/issues/97)) ([59ca2de](https://www.github.com/googleapis/nodejs-precise-date/commit/59ca2de8f6da249808dddebdba3961e59140d06d))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
yoshi-automation added a commit that referenced this pull request Apr 1, 2020
59ca2de
commit 59ca2de
Author: Summer Ji <summerji@google.com>
Date:   Thu Mar 26 11:32:21 2020 -0700

    chore(dep)!: upgrade typescript/gts (#97)

    BFREAKING CHANGE: typescript@3.7.x introduces breaking changes in generated code
yoshi-automation added a commit that referenced this pull request Apr 1, 2020
4037f70
commit 4037f70
Author: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Date:   Thu Mar 26 18:38:16 2020 +0000

    chore: release 2.0.0 (#96)

    🤖 I have created a release \*beep\* \*boop\*
    ---
    ## [2.0.0](https://www.github.com/googleapis/nodejs-precise-date/compare/v1.0.3...v2.0.0) (2020-03-26)

    ### ⚠ BREAKING CHANGES

    * **dep:** upgrade typescript/gts (#97)
    * **dep:** deprecate Node 8 to 10 (#92)

    ### Miscellaneous Chores

    * **dep:** deprecate Node 8 to 10 ([#92](https://www.github.com/googleapis/nodejs-precise-date/issues/92)) ([75ca209](https://www.github.com/googleapis/nodejs-precise-date/commit/75ca209b49abcba8efcbc401b270ac1346874647))
    * **dep:** upgrade typescript/gts ([#97](https://www.github.com/googleapis/nodejs-precise-date/issues/97)) ([59ca2de](https://www.github.com/googleapis/nodejs-precise-date/commit/59ca2de8f6da249808dddebdba3961e59140d06d))
    ---

    This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants