chore(dep)!: upgrade typescript/gts (#97)

BFREAKING CHANGE: typescript@3.7.x introduces breaking changes in generated code

.eslintignore

@@ -1,5 +1,5 @@
 **/node_modules
-src/**/doc/*
+**/.coverage
 build/
 docs/
 protos/

.eslintrc.json

@@ -0,0 +1,3 @@
+{
+  "extends": "./node_modules/gts"
+}

.github/workflows/ci.yaml

@@ -9,7 +9,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node: [8, 10, 12, 13]
+        node: [10, 12, 13]
     steps:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v1

.prettierignore

@@ -1,3 +1,5 @@
-node_modules/*
-samples/node_modules/*
-src/**/doc/*
+**/node_modules
+**/.coverage
+build/
+docs/
+protos/

.prettierrc.js

@@ -0,0 +1,17 @@
+// Copyright 2020 Google LLC
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+module.exports = {
+  ...require('gts/.prettierrc.json')
+}

package.json

@@ -36,14 +36,14 @@
     "@types/mocha": "^7.0.0",
     "@types/node": "^10.5.2",
     "@types/sinon": "^7.0.5",
+    "c8": "^7.0.0",
     "codecov": "^3.0.4",
-    "gts": "^1.0.0",
+    "gts": "next",
     "mocha": "^7.0.0",
-    "c8": "^7.0.0",
     "sinon": "^9.0.0",
-    "typescript": "3.6.4"
+    "typescript": "^3.8.3"
   },
   "engines": {
-    "node": ">=10"
+    "node": ">=10.4.0"
   }
 }

src/index.ts

@@ -124,6 +124,7 @@ export class PreciseDate extends Date {
       return;
     }
 
+    // eslint-disable-next-line prefer-rest-params
     const args: number[] = Array.from(arguments);
     const dateFields = args.slice(0, 7) as DateFields;
     const date = new Date(...dateFields);
@@ -302,7 +303,7 @@ export class PreciseDate extends Date {
 
     const sign = Math.sign(Number(time));
 
-    time = time.replace(/^\-/, '');
+    time = time.replace(/^-/, '');
 
     const seconds = Number(time.substr(0, time.length - 9)) * sign;
     const nanos = Number(time.substr(-9)) * sign;

test/index.ts

@@ -15,7 +15,7 @@
  */
 
 import * as assert from 'assert';
-import {describe, it} from 'mocha';
+import {describe, it, before, beforeEach, after, afterEach} from 'mocha';
 import * as sinon from 'sinon';
 
 import {DateTuple, PreciseDate} from '../src';
@@ -34,7 +34,7 @@ function bigIntFactory(value: number | string): FakeBigInt {
 // while BigInt can't be used as a constructor, Node 11+ will attempt to read
 // members from its prototype chain. We could declare FakeBigInt as a function
 // prototype but that seems to be difficult (impossible?) to do in TypeScript.
-bigIntFactory.prototype.valueOf = function(): number | string {
+bigIntFactory.prototype.valueOf = function (): number | string {
   return this.value;
 };
 
@@ -56,7 +56,7 @@ describe('PreciseDate', () => {
   let RealBigInt: typeof BigInt;
   let date: PreciseDate;
 
-  const NO_BIG_INT_ERR = /BigInt only available in Node \>\= v10\.7. Consider using getFullTimeString instead\./;
+  const NO_BIG_INT_ERR = /BigInt only available in Node >= v10\.7. Consider using getFullTimeString instead\./;
 
   const SECS = 1547253035;
   const NANOS = 381101032;
@@ -77,18 +77,18 @@ describe('PreciseDate', () => {
   const NANOSECONDS = 32;
 
   before(() => {
-    // tslint:disable-next-line no-any
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     RealBigInt = (global as any).BigInt;
   });
 
   beforeEach(() => {
-    // tslint:disable-next-line no-any
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     (global as any).BigInt = bigIntFactory;
     date = new PreciseDate(TIME_STRING);
   });
 
   after(() => {
-    // tslint:disable-next-line no-any
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     (global as any).BigInt = RealBigInt;
   });
 
@@ -104,6 +104,7 @@ describe('PreciseDate', () => {
         .withArgs(TIME_STRING)
         .returns(fakeTimestamp);
 
+      // eslint-disable-next-line @typescript-eslint/no-unused-vars
       const date = new PreciseDate(TIME_STRING);
       const [timestamp] = setStub.lastCall.args;
       assert.strictEqual(timestamp, fakeTimestamp);
@@ -114,6 +115,7 @@ describe('PreciseDate', () => {
       const microsStub = sandbox.stub(PreciseDate.prototype, 'setMicroseconds');
       const nanosStub = sandbox.stub(PreciseDate.prototype, 'setNanoseconds');
 
+      // eslint-disable-next-line @typescript-eslint/no-unused-vars
       const date = new PreciseDate(
         YEAR,
         MONTH,
@@ -141,7 +143,7 @@ describe('PreciseDate', () => {
     });
 
     it('should throw an error if BigInt is unavailable', () => {
-      // tslint:disable-next-line no-any
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
       delete (global as any).BigInt;
 
       assert.throws(() => date.getFullTime(), NO_BIG_INT_ERR);
@@ -453,7 +455,7 @@ describe('PreciseDate', () => {
 
   describe('.fullUTC()', () => {
     it('should throw an error if BigInt is unavailable', () => {
-      // tslint:disable-next-line no-any
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
       delete (global as any).BigInt;
 
       assert.throws(() => PreciseDate.fullUTC(), NO_BIG_INT_ERR);

tsconfig.json

@@ -4,7 +4,7 @@
     "rootDir": ".",
     "outDir": "build",
     "lib": [
-      "es2016",
+      "es2018",
       "esnext.bigint"
     ]
   },