Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(job): remove job instance from request params #465

Merged
merged 3 commits into from May 30, 2019
Merged

fix(job): remove job instance from request params #465

merged 3 commits into from May 30, 2019

Conversation

callmehiphop
Copy link
Contributor

@callmehiphop callmehiphop commented May 30, 2019 •
edited

Fixes #463

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 30, 2019
@callmehiphop callmehiphop mentioned this pull request May 30, 2019
Closed
3 tasks
@codecov
Copy link

codecov bot commented May 30, 2019 •
edited

Codecov Report

Merging #465 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #465      +/-   ##
==========================================
+ Coverage   99.42%   99.42%   +<.01%     
==========================================
  Files           5        5              
  Lines         700      701       +1     
  Branches      194      194              
==========================================
+ Hits          696      697       +1     
  Misses          3        3              
  Partials        1        1
Impacted Files Coverage Δ
src/job.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6add722...29fcada. Read the comment docs.

@codecov
Copy link

codecov bot commented May 30, 2019 •
edited

Codecov Report

Merging #465 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #465      +/-   ##
==========================================
+ Coverage   99.42%   99.42%   +<.01%     
==========================================
  Files           5        5              
  Lines         700      701       +1     
  Branches      194      194              
==========================================
+ Hits          696      697       +1     
  Misses          3        3              
  Partials        1        1
Impacted Files Coverage Δ
src/job.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6add722...29fcada. Read the comment docs.

@callmehiphop callmehiphop merged commit 27f080d into googleapis:master May 30, 2019
@callmehiphop callmehiphop mentioned this pull request Nov 21, 2019
Closed
@release-please release-please bot mentioned this pull request May 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe approved these changes

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

@stephenplusplus stephenplusplus stephenplusplus approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Queries from the Node.js BigQuery client v2.0.0 and higher are not returning results
5 participants
@callmehiphop @bcoe @JustinBeckwith @stephenplusplus @googlebot