Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: store job id instead of job instance #464

Closed
wants to merge 2 commits into from
Closed

fix!: store job id instead of job instance #464

wants to merge 2 commits into from

Conversation

callmehiphop
Copy link
Contributor

@callmehiphop callmehiphop commented May 30, 2019

Fixes #463

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 30, 2019
@callmehiphop
Copy link
Contributor Author

@cmath if you want to give this a test drive to see if it resolves your issue, that would be awesome!

@codecov
Copy link

codecov bot commented May 30, 2019

Codecov Report

Merging #464 into master will increase coverage by 0.42%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #464      +/-   ##
==========================================
+ Coverage   99.42%   99.85%   +0.42%     
==========================================
  Files           5        5              
  Lines         700      701       +1     
  Branches      194      194              
==========================================
+ Hits          696      700       +4     
+ Misses          3        1       -2     
+ Partials        1        0       -1
Impacted Files Coverage Δ
src/index.ts 99.62% <100%> (+1.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d64d892...291ac93. Read the comment docs.

@callmehiphop callmehiphop added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels May 30, 2019
@callmehiphop
Copy link
Contributor Author

Closing in favor of #465 which is not a breaking change.

@callmehiphop callmehiphop deleted the dg--463 branch May 30, 2019 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Queries from the Node.js BigQuery client v2.0.0 and higher are not returning results
2 participants