New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: stop sending RPCs to deleted database #34
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Jan 14, 2020
olavloite
force-pushed
the
database-deleted
branch
from
January 14, 2020 14:32
842c2f7
to
2a5f71e
Compare
olavloite
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jan 14, 2020
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jan 14, 2020
hengfengli
reviewed
Jan 17, 2020
google-cloud-spanner/src/main/java/com/google/cloud/spanner/SessionPool.java
Show resolved
Hide resolved
hengfengli
reviewed
Jan 17, 2020
google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerExceptionFactory.java
Show resolved
Hide resolved
hengfengli
reviewed
Jan 17, 2020
google-cloud-spanner/src/test/java/com/google/cloud/spanner/DatabaseClientImplTest.java
Show resolved
Hide resolved
hengfengli
reviewed
Jan 17, 2020
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITDatabaseTest.java
Show resolved
Hide resolved
hengfengli
approved these changes
Jan 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
olavloite
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jan 20, 2020
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jan 20, 2020
skuruppu
approved these changes
Jan 21, 2020
google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseNotFoundException.java
Outdated
Show resolved
Hide resolved
DatabaseClients should not continue to try to send RPCs to a database that has been deleted. Instead, the session pool will keep track of whether a database not found error has been returned for a database, and if so, will invalidate itself. All subsequent calls for this database will return a DatabaseNotFoundException without calling a RPC. If a database is re-created, the user must create a new DatabaseClient with a new session pool in order to resume usage of the database. Fixes #16
olavloite
force-pushed
the
database-deleted
branch
from
January 22, 2020 06:16
1e26496
to
dd6c56b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DatabaseClients should not continue to try to send RPCs to a database that has been deleted. Instead, the session pool will keep track of whether a DatabaseNotFound error has been returned for a database, and if so, will invalidate itself. All subsequent calls for this database will return a DatabaseNotFoundException without calling a RPC.
If a database is re-created, the user must create a new DatabaseClient with a new session pool in order to resume usage of the database.
Fixes #16