Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: stop sending RPCs to deleted database (#34)
* fix: stop sending rpcs on deleted db * fix: client should stop sending rpcs after database dropped DatabaseClients should not continue to try to send RPCs to a database that has been deleted. Instead, the session pool will keep track of whether a database not found error has been returned for a database, and if so, will invalidate itself. All subsequent calls for this database will return a DatabaseNotFoundException without calling a RPC. If a database is re-created, the user must create a new DatabaseClient with a new session pool in order to resume usage of the database. Fixes #16 * fix: remove double check on isValid * fix: add wait to deleted db integration test * fix: process review comments * fix: update copyright year
- Loading branch information
Showing
7 changed files
with
371 additions
and
55 deletions.
There are no files selected for viewing
34 changes: 34 additions & 0 deletions
34
google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseNotFoundException.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
/* | ||
* Copyright 2020 Google LLC | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package com.google.cloud.spanner; | ||
|
||
import javax.annotation.Nullable; | ||
|
||
/** | ||
* Exception thrown by Cloud Spanner when an operation detects that the database that is being used | ||
* no longer exists. This type of error has its own subclass as it is a condition that should cause | ||
* the client library to stop trying to send RPCs to the backend until the user has taken action. | ||
*/ | ||
public class DatabaseNotFoundException extends SpannerException { | ||
private static final long serialVersionUID = -6395746612598975751L; | ||
|
||
/** Private constructor. Use {@link SpannerExceptionFactory} to create instances. */ | ||
DatabaseNotFoundException( | ||
DoNotConstructDirectly token, @Nullable String message, @Nullable Throwable cause) { | ||
super(token, ErrorCode.NOT_FOUND, false, message, cause); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.