Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set projectId to a default value in emulator case #1345

Closed
wants to merge 5 commits into from
Closed

fix: set projectId to a default value in emulator case #1345

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d8e6320
Set projectId to a default value in emulator case
dmivankov Aug 12, 2021
9740d9e
Update google-cloud-spanner/src/main/java/com/google/cloud/spanner/Sp…
dmivankov Aug 12, 2021
9edd63e
docs: update comment for emulator default project
thiagotnunes Aug 13, 2021
ba4ea34
fix: set emulator project id
thiagotnunes Aug 13, 2021
f28dddb
Update google-cloud-spanner/src/main/java/com/google/cloud/spanner/Sp…
dmivankov Aug 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerOptions.java
View file
Open in desktop
Expand Up @@ -1134,6 +1134,11 @@ public SpannerOptions build() {
this.setChannelConfigurator(ManagedChannelBuilder::usePlaintext);
// As we are using plain text, we should never send any credentials.
this.setCredentials(NoCredentials.getInstance());
// Default project id resolution might fail, but the emulator accepts any
// project id, so we can safely use a dummy id.
if (this.getProjectId() == null) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, may need more work as there's no such getter in ServiceOptions builder and the field is private https://github.com/googleapis/java-core/blob/375983090b3700b3fb6a1953626db7efca49cc51/google-cloud-core/src/main/java/com/google/cloud/ServiceOptions.java#L127

this.setProjetcId("your-project-id");
thiagotnunes marked this conversation as resolved.
Show resolved Hide resolved
}
}
return new SpannerOptions(this);
}
Expand Down