Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set projectId to a default value in emulator case #1345

Closed
wants to merge 5 commits into from
Closed

fix: set projectId to a default value in emulator case #1345

wants to merge 5 commits into from

Commits on Aug 12, 2021

  1. Set projectId to a default value in emulator case 

    Spanner client wants to have a projectId option set, by default it also tries to pick it up from [lots of places](https://github.com/googleapis/java-core/blob/375983090b3700b3fb6a1953626db7efca49cc51/google-cloud-core/src/main/java/com/google/cloud/ServiceOptions.java#L372)
For emulator case none of those may be present as it could be that neither gcloud nor default application credentials are configured, but emulator is accessible nevertheless.

Set default project id in SpannerOptions, value doesn't matter so much as emulator would be happy with any value it seems.
Note that alternatively it could be improved in base ServiceOptions, but not sure about assumptions there.
    @dmivankov
    dmivankov committed Aug 12, 2021
    Copy the full SHA
    d8e6320 View commit details
    Browse the repository at this point in the history

  2. Update google-cloud-spanner/src/main/java/com/google/cloud/spanner/Sp… 

    …annerOptions.java
    @dmivankov
    dmivankov committed Aug 12, 2021
    Copy the full SHA
    9740d9e View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2021

  1. docs: update comment for emulator default project 

    Co-authored-by: Knut Olav Løite <koloite@gmail.com>
    @thiagotnunes @olavloite
    thiagotnunes and olavloite committed Aug 13, 2021
    Copy the full SHA
    9edd63e View commit details
    Browse the repository at this point in the history

  2. fix: set emulator project id 

    Co-authored-by: Knut Olav Løite <koloite@gmail.com>
    @thiagotnunes @olavloite
    thiagotnunes and olavloite committed Aug 13, 2021
    Copy the full SHA
    ba4ea34 View commit details
    Browse the repository at this point in the history

  3. Update google-cloud-spanner/src/main/java/com/google/cloud/spanner/Sp… 

    …annerOptions.java
    @dmivankov
    dmivankov committed Aug 13, 2021
    Copy the full SHA
    f28dddb View commit details
    Browse the repository at this point in the history