New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add success and error callbacks to BulkWriter #483
Merged
Merged
Changes from 22 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
f8e53e7
chore: refactor BulkWriter to use retryBatch
f4d53b4
fix: create new batch for writes to the same doc
9673dfa
refactor BulkWriter's logic in UpdateBuilder into BulkCommitBatch
d92d1da
set MAX_BATCH_SIZE to 20 now that it won't affect WriteBatch/Transact…
3d895e1
cleanup
906165a
add clirr exceptions
2b5f04a
address rd. 1 comments
2133403
change naming to onError and expose callback executors
4ed2e47
add system tests
bee9431
fix: update BulkWriter logic to correctly track user callbacks in flush
BenWhitehead 9a75859
add todo
1ece19e
Merge branch 'bc/bulk-error-with-test' of github.com:googleapis/java-…
1b63018
add slf4j logging to help with debugging
BenWhitehead 49fe275
Move all BulkWriter logic to its own thread + cleanup
a5b372b
Merge branch 'master' into bc/bulk-error-with-test
028e373
remove usage of defaultThreadFactory
95fdcde
resolve comments rd.1
b984f56
remove userCallbackExecutor and add clirr exception
59c89bc
fix flaky test
c46a296
fix flaking batch limiter test
044f925
use directExecutor() in success/error executors by default instead of…
8dc465d
update comment since we're not using synchronized lists anymore
bf03904
resolve ben comments, add coverage
c1264e0
missed a codecov test
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't remove this method without a major version release since it's public. because it's public customers could be using already and we won't want to remove it and break them.
We should be able to keep the method public without any issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed back to public.