New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add success and error callbacks to BulkWriter #483
Commits on Nov 7, 2020
-
chore: refactor BulkWriter to use retryBatch
Brian Chen committedNov 7, 2020 -
fix: create new batch for writes to the same doc
Brian Chen committedNov 7, 2020
Commits on Nov 9, 2020
-
refactor BulkWriter's logic in UpdateBuilder into BulkCommitBatch
Brian Chen committedNov 9, 2020 -
set MAX_BATCH_SIZE to 20 now that it won't affect WriteBatch/Transact…
…ion limits
Brian Chen committedNov 9, 2020 -
Brian Chen committed
Nov 9, 2020 -
Brian Chen committed
Nov 9, 2020
Commits on Nov 10, 2020
-
Brian Chen committed
Nov 10, 2020
Commits on Nov 11, 2020
-
change naming to onError and expose callback executors
Brian Chen committedNov 11, 2020
Commits on Nov 13, 2020
-
Brian Chen committed
Nov 13, 2020 -
fix: update BulkWriter logic to correctly track user callbacks in flush
* Add new userCallbackExecutor which is used to ensure user callbacks aren't able to block any gax thread. Currently this is creating a cached thread pool per writer, we should likely treat this thread pool as a singleton and pass it from the builder to leverage the reuse of the threads even past the lifetime of the writer. * Update instances of setting a SettableFuture to only set after the state operation (add/remove) has completed to ensure and downstream future will only start after state update.
-
Brian Chen committed
Nov 13, 2020 -
Merge branch 'bc/bulk-error-with-test' of github.com:googleapis/java-…
…firestore into bc/bulk-error-with-test
Brian Chen committedNov 13, 2020
Commits on Nov 17, 2020
Commits on Dec 10, 2020
-
Move all BulkWriter logic to its own thread + cleanup
Brian Chen committedDec 10, 2020 -
Merge branch 'master' into bc/bulk-error-with-test
Brian Chen committedDec 10, 2020 -
remove usage of defaultThreadFactory
Brian Chen committedDec 10, 2020
Commits on Dec 11, 2020
-
Brian Chen committed
Dec 11, 2020
Commits on Dec 12, 2020
-
remove userCallbackExecutor and add clirr exception
Brian Chen committedDec 12, 2020 -
Brian Chen committed
Dec 12, 2020
Commits on Dec 14, 2020
-
fix flaking batch limiter test
Brian Chen committedDec 14, 2020 -
use directExecutor() in success/error executors by default instead of…
… wasting logic
Brian Chen committedDec 14, 2020 -
update comment since we're not using synchronized lists anymore
Brian Chen committedDec 14, 2020
Commits on Dec 17, 2020
-
resolve ben comments, add coverage
Brian Chen committedDec 17, 2020 -
Brian Chen committed
Dec 17, 2020