Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add success and error callbacks to BulkWriter #483

Merged
merged 24 commits into from Jan 14, 2021

Commits on Nov 7, 2020

  1. chore: refactor BulkWriter to use retryBatch

    Brian Chen committed Nov 7, 2020
    Copy the full SHA
    f8e53e7 View commit details
    Browse the repository at this point in the history
  2. fix: create new batch for writes to the same doc

    Brian Chen committed Nov 7, 2020
    Copy the full SHA
    f4d53b4 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2020

  1. Copy the full SHA
    9673dfa View commit details
    Browse the repository at this point in the history
  2. set MAX_BATCH_SIZE to 20 now that it won't affect WriteBatch/Transact…

    …ion limits
    Brian Chen committed Nov 9, 2020
    Copy the full SHA
    d92d1da View commit details
    Browse the repository at this point in the history
  3. cleanup

    Brian Chen committed Nov 9, 2020
    Copy the full SHA
    3d895e1 View commit details
    Browse the repository at this point in the history
  4. add clirr exceptions

    Brian Chen committed Nov 9, 2020
    Copy the full SHA
    906165a View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2020

  1. address rd. 1 comments

    Brian Chen committed Nov 10, 2020
    Copy the full SHA
    2b5f04a View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2020

  1. change naming to onError and expose callback executors

    Brian Chen committed Nov 11, 2020
    Copy the full SHA
    2133403 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2020

  1. add system tests

    Brian Chen committed Nov 13, 2020
    Copy the full SHA
    4ed2e47 View commit details
    Browse the repository at this point in the history
  2. fix: update BulkWriter logic to correctly track user callbacks in flush

    * Add new userCallbackExecutor which is used to ensure user callbacks aren't able to block any gax thread. Currently this is creating a cached thread pool per writer, we should likely treat this thread pool as a singleton and pass it from the builder to leverage the reuse of the threads even past the lifetime of the writer.
    * Update instances of setting a SettableFuture to only set after the state operation (add/remove) has completed to ensure and downstream future will only start after state update.
    BenWhitehead committed Nov 13, 2020
    Copy the full SHA
    bee9431 View commit details
    Browse the repository at this point in the history
  3. add todo

    Brian Chen committed Nov 13, 2020
    Copy the full SHA
    9a75859 View commit details
    Browse the repository at this point in the history
  4. Merge branch 'bc/bulk-error-with-test' of github.com:googleapis/java-…

    …firestore into bc/bulk-error-with-test
    Brian Chen committed Nov 13, 2020
    Copy the full SHA
    1ece19e View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2020

  1. Copy the full SHA
    1b63018 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2020

  1. Move all BulkWriter logic to its own thread + cleanup

    Brian Chen committed Dec 10, 2020
    Copy the full SHA
    49fe275 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'master' into bc/bulk-error-with-test

    Brian Chen committed Dec 10, 2020
    Copy the full SHA
    a5b372b View commit details
    Browse the repository at this point in the history
  3. remove usage of defaultThreadFactory

    Brian Chen committed Dec 10, 2020
    Copy the full SHA
    028e373 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2020

  1. resolve comments rd.1

    Brian Chen committed Dec 11, 2020
    Copy the full SHA
    95fdcde View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2020

  1. remove userCallbackExecutor and add clirr exception

    Brian Chen committed Dec 12, 2020
    Copy the full SHA
    b984f56 View commit details
    Browse the repository at this point in the history
  2. fix flaky test

    Brian Chen committed Dec 12, 2020
    Copy the full SHA
    59c89bc View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2020

  1. fix flaking batch limiter test

    Brian Chen committed Dec 14, 2020
    Copy the full SHA
    c46a296 View commit details
    Browse the repository at this point in the history
  2. use directExecutor() in success/error executors by default instead of…

    … wasting logic
    Brian Chen committed Dec 14, 2020
    Copy the full SHA
    044f925 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    8dc465d View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2020

  1. resolve ben comments, add coverage

    Brian Chen committed Dec 17, 2020
    Copy the full SHA
    bf03904 View commit details
    Browse the repository at this point in the history
  2. missed a codecov test

    Brian Chen committed Dec 17, 2020
    Copy the full SHA
    c1264e0 View commit details
    Browse the repository at this point in the history