fix: make keepalive params a bit conservative #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
|
@ejona86 and @igorbernstein2 FYI |
product-auto-label
bot
added
the
api: bigtable
Codecov Report
@@ Coverage Diff @@
## master #528 +/- ##
============================================
- Coverage 81.28% 81.27% -0.01%
Complexity 1129 1129
============================================
Files 106 106
Lines 7047 7045 -2
Branches 370 370
============================================
- Hits 5728 5726 -2
Misses 1119 1119
Partials 200 200
Continue to review full report at Codecov.
|
kolea2
approved these changes
Nov 13, 2020
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Nov 16, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [1.18.0](https://www.github.com/googleapis/java-bigtable/compare/v1.17.3...v1.18.0) (2020-11-13) ### Features * **autogenerated:** Update BigtableTableAdmin GetIamPolicy to include the additional binding for Backup, Change DeleteAppProfileRequest.ignore_warnings to REQUIRED. ([#530](https://www.github.com/googleapis/java-bigtable/issues/530)) ([8c16fa4](https://www.github.com/googleapis/java-bigtable/commit/8c16fa4c5290f67c43392953095bd759c2505bdb)) ### Bug Fixes * make keepalive params a bit conservative ([#528](https://www.github.com/googleapis/java-bigtable/issues/528)) ([f5f66c9](https://www.github.com/googleapis/java-bigtable/commit/f5f66c9ce019a6a24ddfe1efc0141835f5a02f34)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
ad548
pushed a commit
to ad548/java-bigtable
that referenced
this pull request
Mar 13, 2021
ad548
pushed a commit
to ad548/java-bigtable
that referenced
this pull request
Mar 13, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [1.18.0](https://www.github.com/googleapis/java-bigtable/compare/v1.17.3...v1.18.0) (2020-11-13) ### Features * **autogenerated:** Update BigtableTableAdmin GetIamPolicy to include the additional binding for Backup, Change DeleteAppProfileRequest.ignore_warnings to REQUIRED. ([googleapis#530](https://www.github.com/googleapis/java-bigtable/issues/530)) ([8c16fa4](https://www.github.com/googleapis/java-bigtable/commit/8c16fa4c5290f67c43392953095bd759c2505bdb)) ### Bug Fixes * make keepalive params a bit conservative ([googleapis#528](https://www.github.com/googleapis/java-bigtable/issues/528)) ([f5f66c9](https://www.github.com/googleapis/java-bigtable/commit/f5f66c9ce019a6a24ddfe1efc0141835f5a02f34)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having keepalive pings at 10s can cause too_many_ping commands and it will double the keepalive time for new connections on that channel.
This PR sets keepalive pings at 30s (allowed by Google Frontends) which will avoid too many pings warnings.
Do not set keepAliveWithoutCalls(true) as enabling keepalive on idle streams can increase load.