Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bigtable: update keepalive values #5662

Closed
kolea2 opened this issue Dec 28, 2020 · 1 comment · Fixed by #5969
Closed

bigtable: update keepalive values #5662

kolea2 opened this issue Dec 28, 2020 · 1 comment · Fixed by #5969
Assignees
@coryan
Labels
api: bigtable Issues related to the Bigtable API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@kolea2
Copy link

kolea2 commented Dec 28, 2020

Update bigtable keepalive values:
keepalive time: 30s
keepalive timeout: 10s

Example Java reference:
googleapis/java-bigtable#528
@kolea2 kolea2 added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Dec 28, 2020
@coryan coryan added the api: bigtable Issues related to the Bigtable API. label Dec 28, 2020
@coryan coryan self-assigned this Mar 4, 2021
@coryan
Copy link
Member

coryan commented Mar 4, 2021

The C++ client does not set any keepalive parameters at the moment. I am going to assume we want to turn them on.

@coryan coryan mentioned this issue Mar 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coryan coryan

Labels
api: bigtable Issues related to the Bigtable API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(bigtable): enable keepalive pings by default coryan/google-cloud-cpp
2 participants
@coryan @kolea2