fix: retry rst stream #3000
Merged
fix: retry rst stream #3000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigtable
google-cla
bot
added
the
cla: yes
|
Can you rebase on to master? The integration tests should be less flaky |
igorbernstein2
requested changes
May 27, 2021
| @@ -263,6 +265,19 @@ protected boolean isRequestRetryable() { | |||
| return rpc.isRetryable(getRetryRequest()); | |||
| } | |||
|
|
|||
| private boolean isRstStream(Status status) { | |||
| if (!(this instanceof RetryingReadRowsOperation) || status.getCode() != Code.INTERNAL) { | |||
There was a problem hiding this comment.
I think we can improve the isntanceof here
Maybe create a new method isRetryable(Status) which is:
protected boolean isRetryable(Status s) {
return retryOptions.isRetryable(code);
}
and override it in RetryReadRowsoperation:
@OverRide
protected boolean isRetryable(Status s) {
return isRstStream(Status status) || super.isRetryable(code);
}
...lient-core/src/main/java/com/google/cloud/bigtable/grpc/async/AbstractRetryingOperation.java
Outdated
Show resolved
Hide resolved
kolea2
pushed a commit
to kolea2/cloud-bigtable-client
that referenced
this pull request
Sep 10, 2021
* fix: retry rst stream * check if operation is readrows * Refactor * refactor
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Sep 10, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [1.20.0-sp.3](https://www.github.com/googleapis/java-bigtable-hbase/compare/1.20.0-sp.2...v1.20.0-sp.3) (2021-09-10) ### Bug Fixes * retry rst stream (port of [#3000](https://www.github.com/googleapis/java-bigtable-hbase/issues/3000)) ([#3211](https://www.github.com/googleapis/java-bigtable-hbase/issues/3211)) ([9f63882](https://www.github.com/googleapis/java-bigtable-hbase/commit/9f6388228d94d78ef1676a86dc39ad849629ea88)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was fixed in veneer client in https://github.com/googleapis/java-bigtable/pull/586/files but not fixed in bigtable-client-core.
I also noticed different error messages:
"Received Rst stream" mentioned in the original issue
"RST_STREAM closed stream" from b/189326784
"Received RST_STREAM" mentioned in b/179093825
So checking all 3 cases.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #2177 ☕️