feat: add support for table snapshot #1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows users to generate a persistent copy of an existing table as it were at a given point in time within the same project.
product-auto-label
bot
added
the
api: bigquery
google-cla
bot
added
the
cla: yes
shollyman
reviewed
May 18, 2021
google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/CopyJobConfiguration.java
Outdated
Show resolved
Hide resolved
google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/SnapshotDefinition.java
Outdated
Show resolved
Hide resolved
google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITBigQueryTest.java
Outdated
Show resolved
Hide resolved
google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITBigQueryTest.java
Outdated
Show resolved
Hide resolved
google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITBigQueryTest.java
Outdated
Show resolved
Hide resolved
google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/TableDefinition.java
Show resolved
Hide resolved
shollyman
approved these changes
May 20, 2021
google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITBigQueryTest.java
Outdated
Show resolved
Hide resolved
| assertTrue(snapshotTable.getDefinition() instanceof SnapshotTableDefinition); | ||
| assertEquals(TABLE_SCHEMA, snapshotTable.getDefinition().getSchema()); | ||
| assertNotNull(((SnapshotTableDefinition) snapshotTable.getDefinition()).getSnapshotTime()); | ||
| assertEquals( |
There was a problem hiding this comment.
Any reason you didn't just compare tableIds? Something with relative resolution of project?
There was a problem hiding this comment.
Yes, I would get this error if comparing tableIds:
java.lang.AssertionError:
Expected :GenericData{classInfo=[datasetId, projectId, tableId], {datasetId=gcloud_test_dataset_temp_413a3914_e293_4da3_a3cd_e691ba96cdd1, tableId=test_copy_job_base_table}}
Actual :GenericData{classInfo=[datasetId, projectId, tableId], {datasetId=gcloud_test_dataset_temp_413a3914_e293_4da3_a3cd_e691ba96cdd1, projectId=java-docs-samples-testing, tableId=test_copy_job_base_table}}
So I am comparing just the tableNames.
google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITBigQueryTest.java
Outdated
Show resolved
Hide resolved
stephaniewang526
added
the
do not merge
|
Will not merge until this feature is launched. |
stephaniewang526
removed
the
do not merge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jun 28, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [1.135.0](https://www.github.com/googleapis/java-bigquery/compare/v1.134.1...v1.135.0) (2021-06-28) ### Features * add support for table snapshot ([#1320](https://www.github.com/googleapis/java-bigquery/issues/1320)) ([d783292](https://www.github.com/googleapis/java-bigquery/commit/d783292f4bd2d971235d8afa6318976856529cb5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
gcf-owl-bot bot
added a commit
that referenced
this pull request
Jan 10, 2022
…-processor (#1320) Source-Link: googleapis/synthtool@4b86ab0 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:efbfc5e9ff713005a037941f8ebcc0c69cc630e3ad934675ee26868705a30897
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for
operationTypeinCopyJobConfiguration.javaand added class support forSnapshotDefinition.