Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: accept 201 Created as valid upload response #141

Merged
merged 2 commits into from Jul 23, 2020
Merged

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jul 23, 2020

Supersedes: #125

Fixes: #124

@google-cla
Copy link

google-cla bot commented Jul 23, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Jul 23, 2020
@frankyn frankyn self-requested a review July 23, 2020 18:10
@tseaver
Copy link
Contributor Author

tseaver commented Jul 23, 2020

@lisandromc I was unable to push my test fix to your branch, and so have pushed it to this repo. Please respond with @googlebot I consent to allow this branch to move forward with your change.

@google-cla
Copy link

google-cla bot commented Jul 23, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@tseaver tseaver changed the title fix: accept 201 Created as valid upload response. fix: accept 201 Created as valid upload response Jul 23, 2020
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 23, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 23, 2020
@tseaver
Copy link
Contributor Author

tseaver commented Jul 23, 2020

@frankyn I guess you could flip the CLA flag manually, since we know that @lisandromc wanted the change to land in #125.

@frankyn frankyn added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload initiation fails due to asserting wrong HTTP status code
4 participants