fix: accept 201 Created as valid upload initiation response

[lisandromc]

Accepts HTTP 201 Created as a valid upload initiation response

Fixes #124

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[lisandromc]

@googlebot I signed it!

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[frankyn]

Left a question before continuing.

[frankyn]

Hi @lisandromc, thanks again for sending this change. Could you show me an example of when this fails? At the moment a 201 isn't expected when a resumable session is initialized: https://cloud.google.com/storage/docs/performing-resumable-uploads#initiate-session

[frankyn]

Friendly ping on this question.

[lisandromc]

Hey Frank. I was so busy dealing with other stuff that I overlooked your question, sorry about that.

curl --location --request POST 'https://storage.googleapis.com/dam-staging/Ingest/Blink/Testing/Quinta%20Prueba%20de%20Lich/Photo/Palermo/20191005/dolomites.jpg?GoogleAccessId=digitalassetsmanagement%40production-backup-194719.iam.gserviceaccount.com&Expires=1590596284&Signature=kc1xIWCbHeqr100pSOtlA5GpkO1tLoWgU%2FFUyN3QwGQOOGSOwOoO1XCfqBFAdvYywpTi0QdVjIBnB77nq302o0fkzObgpPCUmCq9uWSS2z9ibkiAQdpwWlR9n4XfC1hn25GYumFjZ161ANxC2M5yrjR91jdYtFu2Z4VGFTN%2BhEl7xtYgQ8GHA%2FWSjfCCEfU%2FY0B4p8GMpiLHL3GZtOmBJvqJsuZdTIKb%2FscqctBNX75VLVw5FaWadkj8s0CyIRLM69jy00aPfNO%2BSrfcm4z7PHE6FV8yeJdewoXvJnRDgT0CZDAU7UzgPA4rhqSutcjQT0VkPrN6CHqniEMvhTWaLg%3D%3D' \
> --header 'x-goog-resumable: start' \
> --header 'x-upload-content-type: application/octet-stream' -D -
HTTP/2 201 
content-type: text/plain; charset=utf-8
x-guploader-uploadid: AAANsUm8Q-L1Oh6afXYzfU15-IxWUj4x_JvH8fXvbdCmv-fEdThwSBo4kh3nTyb-RSuyUoelAOLT94NpMy_aZ7YM89k
location: https://storage.googleapis.com/dam-staging/Ingest/Blink/Testing/Quinta%20Prueba%20de%20Lich/Photo/Palermo/20191005/dolomites.jpg?GoogleAccessId=digitalassetsmanagement%40production-backup-194719.iam.gserviceaccount.com&Expires=1590596284&Signature=kc1xIWCbHeqr100pSOtlA5GpkO1tLoWgU%2FFUyN3QwGQOOGSOwOoO1XCfqBFAdvYywpTi0QdVjIBnB77nq302o0fkzObgpPCUmCq9uWSS2z9ibkiAQdpwWlR9n4XfC1hn25GYumFjZ161ANxC2M5yrjR91jdYtFu2Z4VGFTN%2BhEl7xtYgQ8GHA%2FWSjfCCEfU%2FY0B4p8GMpiLHL3GZtOmBJvqJsuZdTIKb%2FscqctBNX75VLVw5FaWadkj8s0CyIRLM69jy00aPfNO%2BSrfcm4z7PHE6FV8yeJdewoXvJnRDgT0CZDAU7UzgPA4rhqSutcjQT0VkPrN6CHqniEMvhTWaLg%3D%3D&upload_id=AAANsUm8Q-L1Oh6afXYzfU15-IxWUj4x_JvH8fXvbdCmv-fEdThwSBo4kh3nTyb-RSuyUoelAOLT94NpMy_aZ7YM89k
content-length: 0
date: Wed, 20 May 2020 16:19:47 GMT
server: UploadServer
alt-svc: h3-27=":443"; ma=2592000,h3-25=":443"; ma=2592000,h3-T050=":443"; ma=2592000,h3-Q050=":443"; ma=2592000,h3-Q049=":443"; ma=2592000,h3-Q048=":443"; ma=2592000,h3-Q046=":443"; ma=2592000,h3-Q043=":443"; ma=2592000,quic=":443"; ma=2592000; v="46,43"

The URL for Google Storage is provided by a separate web service, so I don't have direct control over it. Anyway, the only apparent difference would seem to be the uploadType=resumable param.
I tried adding that parameter, but nothing changed. Still 201 Created.
Also, notice that repeatedly issuing an upload initiation request always yields 201, while one might assume a 201 response for the first time and a 200 for subsequent repeated requests, as it seems to be idempotent.

[frankyn]

Thanks for clarifying that. This change LGTM!

[frankyn]

@lisandromc pending rebasing or merging master into PR and passing tests.

[lisandromc]

@lisandromc pending rebasing or merging master into PR and passing tests.

Merged!

[frankyn]

There are still test failures that need to be addressed. Could you take a look at them?

[frankyn]

@lisandromc apologies, tests needs to be updated and master must be merged again.