fix(pubsub): add deadletter and retries handling in the fake pubsub #5320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
|
Solves #5319 |
hongalex
added
the
kokoro:run
kokoro-team
removed
the
kokoro:run
hongalex
reviewed
Jan 14, 2022
…dead letter policy is set Co-authored-by: Alex Hong <9397363+hongalex@users.noreply.github.com>
yottta
commented
Jan 15, 2022
| if m.deliveries != nil { | ||
| deliveries = *m.deliveries | ||
| } | ||
| s.deadLetterTopic.publish(m.proto.Message, &Message{ |
There was a problem hiding this comment.
Here I doubt that I need to use the original message properties (deliveries and acks) since the publish method is not allowing the proto values as well for these properties.
This is about the changes that you suggested around m.proto.DeliveryAttempt.
Also you can check fake_test.go#382
hongalex
added
the
kokoro:run
kokoro-team
removed
the
kokoro:run
hongalex
approved these changes
Jan 18, 2022
BrennaEpp
pushed a commit
to BrennaEpp/google-cloud-go
that referenced
this pull request
Jan 19, 2022
…oogleapis#5320) * fix(pubsub): add deadletter and retries handling in the fake pubsub server * fix(pubsub): Sync delivery attempt field here before incrementing if dead letter policy is set Co-authored-by: Alex Hong <9397363+hongalex@users.noreply.github.com> * fix(pubsub): delivery attempts to proto as well; typos Co-authored-by: Alex Hong <9397363+hongalex@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client
PubSub
Go Environment
go version go1.16.6 darwin/amd64
Description
The PubSub library offers a testing server that is still in beta and therefore does not have all the functionalities.
This ticket is about improving the PubSub testing server to handle correctly Deadletters and retries.
Expected behavior
When a Subscription is created with a DeadLetter and retries configuration, an unacked message is received from the subscription only as many times as specified in the retries configuration.
Actual behavior
When a Subscription is created with a DeadLetter configuration, an unacked message is never sent to deadletter and is received from the subscription indefinitely.