Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pubsub: pstest - Support iterating on DeliveryAttempt when dead lettering is enabled #5323

Closed
burdzwastaken opened this issue Jan 10, 2022 · 2 comments
Assignees
Labels
api: pubsub Issues related to the Pub/Sub API. triage me I really want to be triaged.

Comments

@burdzwastaken
Copy link

burdzwastaken commented Jan 10, 2022

Is your feature request related to a problem? Please describe.
Enabling dead lettering on pubsub subscription and interacting with it via pstest does not iterate DeliveryAttempt. This makes it hard to test if certain (bad/good) messages will/will not end up in the dead letter queue as they are always currently nil. Here is a code snippet that displays the behaviour we are seeing: https://gist.github.com/burdzwastaken/e3abfc377ea40a4529abf4dca10d12f9

Describe the solution you'd like
We would like pstest to iterate on DeliveryAttempt so that then we could check if bad messages in our tests end up in the dead letter queue after the set value MaxDeliveryAttempts in DeadLetterPolicy is reached.

Describe alternatives you've considered
Currently we are just testing enabling/updating the dead letter queue (which works well!)

@burdzwastaken burdzwastaken added the triage me I really want to be triaged. label Jan 10, 2022
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Jan 10, 2022
@burdzwastaken burdzwastaken changed the title pubsub: pstest - Support iterating on DeliveryAttempts when dead lettering is enabled pubsub: pstest - Support iterating on DeliveryAttempt when dead lettering is enabled Jan 10, 2022
@burdzwastaken
Copy link
Author

This is probably a duplicate of #5319. I just saw the other issue after working on this one last week.

@burdzwastaken
Copy link
Author

#5320

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. triage me I really want to be triaged.
Projects
None yet
Development

No branches or pull requests

2 participants