Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pubsub: fake server does not handle deadletters and retry counts #5319

Closed
yottta opened this issue Jan 8, 2022 · 3 comments
Closed

pubsub: fake server does not handle deadletters and retry counts #5319

yottta opened this issue Jan 8, 2022 · 3 comments
Assignees
@hongalex
Labels
api: pubsub Issues related to the Pub/Sub API. 🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@yottta
Copy link
Contributor

yottta commented Jan 8, 2022 •
edited

Client

PubSub

Go Environment

go version go1.16.6 darwin/amd64

Description

The PubSub library offers a testing server that is still in beta and therefore does not have all the functionalities.
This ticket is about improving the PubSub testing server to handle correctly Deadletters and retries.

Expected behavior

When a Subscription is created with a DeadLetter and retries configuration, an unacked message is received from the subscription only as many times as specified in the retries configuration.

Actual behavior

When a Subscription is created with a DeadLetter configuration, an unacked message is never sent to deadletter and is received from the subscription indefinitely.
@yottta yottta added the triage me I really want to be triaged. label Jan 8, 2022
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Jan 8, 2022
@yottta yottta mentioned this issue Jan 8, 2022
Merged
@burdzwastaken burdzwastaken mentioned this issue Jan 10, 2022
Closed
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Jan 13, 2022
@yottta
Copy link
Contributor Author

yottta commented Jan 19, 2022

Fixed by #5320

@yottta yottta closed this as completed Jan 19, 2022
@burdzwastaken
Copy link

@yottta could the PR #5374 or #5463 get merged soon so this functionality is available? will help with our testing strategy. thank you so much

@burdzwastaken
Copy link

sorry @yottta had a brainfart & didn't realize you were the contributor. thanks for the approval anyway <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hongalex hongalex

Labels
api: pubsub Issues related to the Pub/Sub API. 🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@yottta @hongalex @burdzwastaken @yoshi-automation