Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: generate standalone examples #3916

Closed
tbpg opened this issue Apr 12, 2021 · 2 comments
Closed

all: generate standalone examples #3916

tbpg opened this issue Apr 12, 2021 · 2 comments
Assignees
@tbpg
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@tbpg
Copy link
Contributor

tbpg commented Apr 12, 2021

cc @codyoss @noahdietz
@tbpg tbpg added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Apr 12, 2021
@tbpg tbpg self-assigned this Apr 12, 2021
This was referenced Apr 12, 2021
Merged
Merged
@tbpg
Copy link
Contributor Author

tbpg commented Apr 14, 2021

#3922 and #3924 were also for this, but didn't tag this issue.

gcf-merge-on-green bot pushed a commit that referenced this issue Apr 14, 2021
@tbpg
fix(internal/gensnippets): run goimports (#3931)
10050f0 
Updates #3916.
@tbpg tbpg mentioned this issue Apr 16, 2021
Merged
codyoss pushed a commit that referenced this issue Apr 16, 2021
@tbpg
feat(internal): auto-generate snippets (#3949)
b70e0fc 
I created a new package to make it easier to run than calling the binary. I included a binary for local development.

I needed to install build-base in the Docker image to get gcc, which was needed to Load all packages.

I modified gapics.go to replace genproto in every go.mod because the changes need to be visible everywhere to Load every module.

I ran the generator locally and it seems to work. I only included one directory in this PR because there are a lot of files. I can upload the rest in this PR after initial review.

Updates #3916.
@tbpg tbpg mentioned this issue Apr 16, 2021
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Apr 19, 2021
@codyoss
refactor(internal): move gensnippets into gapicgen (#3954)
98a5598 
Updates #3916.
@tbpg
Copy link
Contributor Author

tbpg commented Aug 12, 2021

Closing, as this is fixed. 😄

@tbpg tbpg closed this as completed Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tbpg tbpg

Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tbpg