refactor(internal/godocfx): move pkg loading to separate package #3917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd like to be able to reuse the package loading function for a new tool. So, to make it importable, I refactored it into another package. There are no changes to the code beyond exporting necessary identifiers (and, you know, moving the code).
google-cla
bot
added
the
cla: yes
noahdietz
approved these changes
Apr 12, 2021
codyoss
approved these changes
Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to be able to reuse the package loading function for example
generation. So, to make it importable, I refactored it into another package.
There are no changes to the code beyond exporting necessary identifiers
(and, you know, moving the code).
I copied the
hasPrefixutility because it's useful. 馃槃This is all internal, so there are no concerns about exporting identifiers and
keeping compatibility over time.
Updates #3916.