Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(internal): move gensnippets into gapicgen #3954

Merged
merged 2 commits into from Apr 19, 2021
Merged

refactor(internal): move gensnippets into gapicgen #3954

merged 2 commits into from Apr 19, 2021

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Apr 16, 2021 •
edited by tbpg

Updates #3916.

@codyoss codyoss requested a review from a team as a code owner April 16, 2021 17:42
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 16, 2021
@codyoss codyoss requested a review from tbpg April 16, 2021 17:43
tbpg
tbpg approved these changes Apr 16, 2021
View reviewed changes
Copy link
Contributor

@tbpg tbpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm a fan of fewer modules.

@codyoss codyoss added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 16, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 16, 2021
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 17, 2021
@tbpg tbpg added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 19, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 19, 2021
@tbpg tbpg added the automerge Merge the pull request once unit tests and other checks pass. label Apr 19, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 98a5598 into googleapis:master Apr 19, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 19, 2021
@codyoss codyoss deleted the ref-gensnippets branch September 11, 2021 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbpg tbpg tbpg approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codyoss @tbpg @kokoro-team