Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use FUNCTION_TARGET to detect GCF 10 and above #748

Merged
merged 2 commits into from Jul 19, 2019
Merged

fix: use FUNCTION_TARGET to detect GCF 10 and above #748

merged 2 commits into from Jul 19, 2019

Conversation

JustinBeckwith
Copy link
Contributor

@JustinBeckwith JustinBeckwith commented Jul 17, 2019 •
edited

Fixes #747

@steren FYI

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 17, 2019
@ofrobots
Copy link
Contributor

Would this work correctly on a function running on Cloud Run? See also my comment here: #747 (comment)

@codecov
Copy link

codecov bot commented Jul 17, 2019 •
edited

Codecov Report

Merging #748 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #748   +/-   ##
=======================================
  Coverage   84.41%   84.41%           
=======================================
  Files          17       17           
  Lines         943      943           
  Branches      210      211    +1     
=======================================
  Hits          796      796           
  Misses         87       87           
  Partials       60       60
Impacted Files Coverage Δ
src/auth/envDetect.ts 89.28% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90c563f...2c40988. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 19, 2019 •
edited

Codecov Report

Merging #748 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #748   +/-   ##
=======================================
  Coverage   84.41%   84.41%           
=======================================
  Files          17       17           
  Lines         943      943           
  Branches      210      211    +1     
=======================================
  Hits          796      796           
  Misses         87       87           
  Partials       60       60
Impacted Files Coverage Δ
src/auth/envDetect.ts 89.28% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 131489e...c4a8de9. Read the comment docs.

@JustinBeckwith JustinBeckwith merged commit ca17685 into master Jul 19, 2019
@JustinBeckwith
Copy link
Contributor Author

Chatted with @steren offline - this is fine as a tactical fix, but we do need to drive a better effort forward that uses the metadata server.

This was referenced Aug 26, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe approved these changes

@ofrobots ofrobots Awaiting requested review from ofrobots

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Environment detection does not work on GCF nodejs10
4 participants
@JustinBeckwith @ofrobots @bcoe @googlebot