Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logs not shown for Cloud Function nodejs10 runtime #333

Closed
MatthieuLemoine opened this issue Jun 5, 2019 · 9 comments
Closed

Logs not shown for Cloud Function nodejs10 runtime #333

MatthieuLemoine opened this issue Jun 5, 2019 · 9 comments
Assignees
Labels
api: logging Issues related to the googleapis/nodejs-logging-winston API. priority: p2 Moderately-important priority. Fix may not be included in next release. 🚨 This issue needs some love. status: blocked Resolving the issue is dependent on other work. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@MatthieuLemoine
Copy link

Environment details

  • OS: Cloud Function
  • Node.js version: 10.15.x
  • npm version:
  • @google-cloud/logging-winston version:0.11.1

Steps to reproduce

  1. Create a custom logger using logging-winston as transport
  2. Deploy the cloud function on nodejs10 runtime
  3. Logs are not shown in Stackdriver Log viewer

While trying to migrate from Cloud function nodejs8 to nodejs10 runtime, I found out that logs are not shown in Stackdriver Log viewer. If I change the runtime back to nodejs8, it's working as intended.

Let me know if I should create an issue in Cloud Function's issue tracker on https://issuetracker.google.com

@ofrobots
Copy link
Contributor

ofrobots commented Jun 5, 2019

Related: googleapis/nodejs-logging-bunyan#291, with the root cause in googleapis/nodejs-logging-bunyan#291 (comment).

We're working with the Cloud Functions team to get this resolved /cc @steren.

@JustinBeckwith JustinBeckwith added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jun 5, 2019
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Jun 6, 2019
@yoshi-automation yoshi-automation removed the triage me I really want to be triaged. label Jun 7, 2019
@ofrobots
Copy link
Contributor

@steren this is blocked on the Cloud Functions side. I don't have permissions to open an issue against Cloud Functions on https://issuetracker.google.com. Can open a bug on that side?

@steren
Copy link

steren commented Jun 11, 2019

We have an internal tracking bug (131353611)

@ofrobots
Copy link
Contributor

@steren is there a public version of the bug so that @MatthieuLemoine can follow along on progress?

@steren
Copy link

steren commented Jun 11, 2019

This GitHub issue? I do not see the advantage of creating one more issue.

@JustinBeckwith JustinBeckwith added priority: p2 Moderately-important priority. Fix may not be included in next release. status: blocked Resolving the issue is dependent on other work. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Jun 11, 2019
@tanishiking
Copy link

tanishiking commented Aug 26, 2019

Hi there, this problem seems fixed in googleapis/google-auth-library-nodejs#748 which is available as of google-auth-library v4.2.6, right?
I confirmed that it is working correctly in my following environment.

  • Google Cloud Function with nodejs10
  • @google-cloud/logging-winston version: 1.1.1

Thank you so much for working on this issue :)

@bcoe
Copy link
Contributor

bcoe commented Aug 26, 2019

@MatthieuLemoine 👋 can you confirm that this issue is fixed for you?

@soldair
Copy link
Contributor

soldair commented Aug 30, 2019

@MatthieuLemoine some details i added here might help you work around the issue for now.
googleapis/nodejs-logging-bunyan#291 (comment)

@bcoe bcoe closed this as completed Sep 5, 2019
@bcoe
Copy link
Contributor

bcoe commented Sep 5, 2019

@MatthieuLemoine @soldair I've gone ahead and closed this issue, because it sounds like we addressed it in a patch to google-auth-library-nodejs; please feel free to reopen if you're continuing to bump into issues.

@google-cloud-label-sync google-cloud-label-sync bot added the api: logging Issues related to the googleapis/nodejs-logging-winston API. label Jan 31, 2020
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/nodejs-logging-winston API. priority: p2 Moderately-important priority. Fix may not be included in next release. 🚨 This issue needs some love. status: blocked Resolving the issue is dependent on other work. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

8 participants