fix: use iam client library to setup test #1173
Conversation
google-cla
bot
added
the
cla: yes
xil222
changed the title
xil222
changed the title
package.json
Outdated
| @@ -23,6 +23,8 @@ | |||
| "fast-text-encoding": "^1.0.0", | |||
| "gaxios": "^4.0.0", | |||
| "gcp-metadata": "^4.2.0", | |||
| "google-auth-library": "^7.0.4", | |||
There was a problem hiding this comment.
If these are just being used in samples, you would need to add them to samples/package.json. There should already be a reference to google-auth-library there, since it gets linked in as part of the tests.
There was a problem hiding this comment.
+1.
You just need to add the additional dependency, e.g. googleapis which can probably go here:
| // changes. | ||
| // https://cloud.google.com/iam/docs/reference/rest/v1beta/projects.locations.workloadIdentityPools | ||
| // https://github.com/googleapis/google-api-nodejs-client/tree/master/src/apis/iam | ||
| const authClient = await auth.getClient(); |
There was a problem hiding this comment.
You can skip this line entirely and say google.options({auth}); and it will work just the same :)
package.json
Outdated
| @@ -23,6 +23,8 @@ | |||
| "fast-text-encoding": "^1.0.0", | |||
| "gaxios": "^4.0.0", | |||
| "gcp-metadata": "^4.2.0", | |||
| "google-auth-library": "^7.0.4", | |||
There was a problem hiding this comment.
+1.
You just need to add the additional dependency, e.g. googleapis which can probably go here:
| policy: { | ||
| bindings, | ||
| }, | ||
| } |
There was a problem hiding this comment.
A lot of the lint errors can be fixed by running npm run fix.
You can also see the list of errors by running npm run lint. This is useful for the errors that require manual fixing.
| // changes. | ||
| // https://cloud.google.com/iam/docs/reference/rest/v1beta/projects.locations.workloadIdentityPools | ||
| // https://github.com/googleapis/google-api-nodejs-client/tree/master/src/apis/iam | ||
| const authClient = await auth.getClient(); |
| }, | ||
| response = await iam.projects.locations.workloadIdentityPools.create({ | ||
| parent: `projects/${projectId}/locations/global`, | ||
| workloadIdentityPoolId: poolId, |
There was a problem hiding this comment.
Can you also add a display name and description: https://github.com/googleapis/google-api-nodejs-client/blob/19bd611ca69f334b342565698a8ec8991e956580/src/apis/iam/v1.ts#L2412
This makes it easy to understand who created this pool (It will also work well in the Cloud Console UI).
|
@bcoe this is one of the action items from when we added the integration tests before launch. Your input is highly appreciated. |
samples/package.json
Outdated
| @@ -14,6 +14,7 @@ | |||
| "license": "Apache-2.0", | |||
| "dependencies": { | |||
| "google-auth-library": "^7.1.0", | |||
| "googleapis": "^73.0.0", | |||
There was a problem hiding this comment.
Could I get you to try out https://www.npmjs.com/package/@googleapis/iam, I love to stress test our individual modules, and it should improve install size.
There was a problem hiding this comment.
Thanks for your feedback. In externalclient-setup.js, I still need to set auth with import from googleapis:
google.options({auth});
I am not able to setup the auth if only install @googleapis/iam for this case.
There was a problem hiding this comment.
won't this work?
const Iam = require('@googleapis/iam')
const iam = await iam.iam({
version: 'v1',
auth
});
const response = await iam.projects.locations.workloadIdentityPools.create({});You can pass auth to the client itself, it doesn't need to be configured globally (perhaps I'm missing the issue though.).
There was a problem hiding this comment.
yes, this is working. Thank you.
JustinBeckwith
added
the
kokoro:force-run
bcoe
added
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
🤖 I have created a release \*beep\* \*boop\* --- ### [7.1.2](https://www.github.com/googleapis/google-auth-library-nodejs/compare/v7.1.1...v7.1.2) (2021-06-10) ### Bug Fixes * use iam client library to setup test ([#1173](https://www.github.com/googleapis/google-auth-library-nodejs/issues/1173)) ([74ac5db](https://www.github.com/googleapis/google-auth-library-nodejs/commit/74ac5db59f9eff8fa4f3bdb6acc0647a1a4f491f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This PR is for implementing using IAM client library for setting up externalClient tests, without making any changes to
current tests.
The bug could be tracked from b/185501294.
@bojeil-google