-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use iam client library to setup test #1173
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
fbc7cf5
Use iam client library to setup test
xil222 d79f3bc
fix: Update Node.js integration test setup to use iam client library.
xil222 e221bb8
Merge branch 'xinxinxin-iamSetUp' of https://github.com/xil222/google…
xil222 d0acc25
fix: revert package.json changes
xil222 034db74
Merge branch 'master' into xinxinxin-iamSetUp
JustinBeckwith def899a
fix lint errors and improve code
xil222 8eadf53
Merge branch 'xinxinxin-iamSetUp' of https://github.com/xil222/google…
xil222 3d29182
Merge branch 'master' into xinxinxin-iamSetUp
xil222 d8ee675
Merge branch 'master' into xinxinxin-iamSetUp
xil222 822d289
direct use iam
xil222 0d628f0
update package version
xil222 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add a display name and description: https://github.com/googleapis/google-api-nodejs-client/blob/19bd611ca69f334b342565698a8ec8991e956580/src/apis/iam/v1.ts#L2412
This makes it easy to understand who created this pool (It will also work well in the Cloud Console UI).