Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): require uritemplate 3.0.1 #1629

Merged
merged 5 commits into from Dec 13, 2021
Merged

fix(deps): require uritemplate 3.0.1 #1629

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e60da21
fix(deps): require uritemplate 3.0.1
parthea Dec 13, 2021
6fa1e10
Merge branch 'main' into require-uritemplate-3-0-1
parthea Dec 13, 2021
a18d0cc
revert testing/constraints-3.10.txt
parthea Dec 13, 2021
ccdee5e
Merge branch 'main' into require-uritemplate-3-0-1
parthea Dec 13, 2021
0e65155
Merge branch 'main' into require-uritemplate-3-0-1
parthea Dec 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Expand Up @@ -42,7 +42,7 @@
# Until this issue is closed
# https://github.com/googleapis/google-cloud-python/issues/10566
"google-api-core>=1.21.0,<3.0.0dev",
"uritemplate>=3.0.0,<5",
"uritemplate>=3.0.1,<5",
]

package_root = os.path.abspath(os.path.dirname(__file__))
Expand Down
8 changes: 8 additions & 0 deletions testing/constraints-3.10.txt
View file
Open in desktop
@@ -0,0 +1,8 @@
# This constraints file is used to check that lower bounds
# are correct in setup.py
# List *all* library dependencies and extras in this file.
# Pin the version to the lower bound.
#
# e.g., if setup.py has "foo >= 1.14.0, < 2.0.0dev",
# Then this file should have foo==1.14.0
uritemplate==3.0.1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we normally pin the minimum version in the constraints file that targets the minimum Python version supported? It would IMO make sense to explain with a comment why this particular constraint lives in the constraints-3.10 file as well (unless this particular library is different).

2 changes: 1 addition & 1 deletion testing/constraints-3.6.txt
View file
Open in desktop
Expand Up @@ -9,4 +9,4 @@ httplib2==0.15.0
google-auth==1.16.0
google-auth-httplib2==0.0.3
google-api-core==1.21.0
uritemplate==3.0.0
uritemplate==3.0.1